* [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h
@ 2011-01-10 21:44 Jason Liu
2011-01-10 22:31 ` Uwe Kleine-König
2011-01-10 23:52 ` Richard Zhao
0 siblings, 2 replies; 3+ messages in thread
From: Jason Liu @ 2011-01-10 21:44 UTC (permalink / raw)
To: linux-arm-kernel
There are devices-imx51.h and devices-imx53.h under
arch/arm/mach-mx5 directory. So, had better rename
devices-mx50.h to devices-imx50.h to follow the same
naming convention with imx51 and imx53 part.
Signed-off-by: Jason Liu <r64343@freescale.com>
---
arch/arm/mach-mx5/board-mx50_rdp.c | 2 +-
.../mach-mx5/{devices-mx50.h => devices-imx50.h} | 0
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx50_rdp.c b/arch/arm/mach-mx5/board-mx50_rdp.c
index fd32e4c..e5bb600 100644
--- a/arch/arm/mach-mx5/board-mx50_rdp.c
+++ b/arch/arm/mach-mx5/board-mx50_rdp.c
@@ -35,7 +35,7 @@
#include <asm/mach/arch.h>
#include <asm/mach/time.h>
-#include "devices-mx50.h"
+#include "devices-imx50.h"
static iomux_v3_cfg_t mx50_rdp_pads[] __initdata = {
/* SD1 */
diff --git a/arch/arm/mach-mx5/devices-mx50.h b/arch/arm/mach-mx5/devices-imx50.h
similarity index 100%
rename from arch/arm/mach-mx5/devices-mx50.h
rename to arch/arm/mach-mx5/devices-imx50.h
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h
2011-01-10 21:44 [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h Jason Liu
@ 2011-01-10 22:31 ` Uwe Kleine-König
2011-01-10 23:52 ` Richard Zhao
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2011-01-10 22:31 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 11, 2011 at 05:44:29AM +0800, Jason Liu wrote:
> There are devices-imx51.h and devices-imx53.h under
> arch/arm/mach-mx5 directory. So, had better rename
> devices-mx50.h to devices-imx50.h to follow the same
> naming convention with imx51 and imx53 part.
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-mx5/board-mx50_rdp.c | 2 +-
> .../mach-mx5/{devices-mx50.h => devices-imx50.h} | 0
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/board-mx50_rdp.c b/arch/arm/mach-mx5/board-mx50_rdp.c
> index fd32e4c..e5bb600 100644
> --- a/arch/arm/mach-mx5/board-mx50_rdp.c
> +++ b/arch/arm/mach-mx5/board-mx50_rdp.c
> @@ -35,7 +35,7 @@
> #include <asm/mach/arch.h>
> #include <asm/mach/time.h>
>
> -#include "devices-mx50.h"
> +#include "devices-imx50.h"
>
> static iomux_v3_cfg_t mx50_rdp_pads[] __initdata = {
> /* SD1 */
> diff --git a/arch/arm/mach-mx5/devices-mx50.h b/arch/arm/mach-mx5/devices-imx50.h
> similarity index 100%
> rename from arch/arm/mach-mx5/devices-mx50.h
> rename to arch/arm/mach-mx5/devices-imx50.h
> --
> 1.7.0.4
>
>
>
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h
2011-01-10 21:44 [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h Jason Liu
2011-01-10 22:31 ` Uwe Kleine-König
@ 2011-01-10 23:52 ` Richard Zhao
1 sibling, 0 replies; 3+ messages in thread
From: Richard Zhao @ 2011-01-10 23:52 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 11, 2011 at 5:44 AM, Jason Liu <r64343@freescale.com> wrote:
> There are devices-imx51.h and devices-imx53.h under
> arch/arm/mach-mx5 directory. So, had better rename
> devices-mx50.h to devices-imx50.h to follow the same
> naming convention with imx51 and imx53 part.
I noticed that too. Sometimes we use imx as part of file name or macro
name, but other times we use mx . We'd better make some rule that when
and where we suppose to use what.
I suggest we move all to mx for short. Reasons:
- For freescale internal, starting from mx5, we all use mx.
- macros in soc header files all use mx.
- soc header file name all use mx too.
- mach-types all use mx. (count in freescale board only)
Thanks
Richard
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
> ---
> ?arch/arm/mach-mx5/board-mx50_rdp.c ? ? ? ? ? ? ? ? | ? ?2 +-
> ?.../mach-mx5/{devices-mx50.h => devices-imx50.h} ? | ? ?0
> ?2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/board-mx50_rdp.c b/arch/arm/mach-mx5/board-mx50_rdp.c
> index fd32e4c..e5bb600 100644
> --- a/arch/arm/mach-mx5/board-mx50_rdp.c
> +++ b/arch/arm/mach-mx5/board-mx50_rdp.c
> @@ -35,7 +35,7 @@
> ?#include <asm/mach/arch.h>
> ?#include <asm/mach/time.h>
>
> -#include "devices-mx50.h"
> +#include "devices-imx50.h"
>
> ?static iomux_v3_cfg_t mx50_rdp_pads[] __initdata = {
> ? ? ? ?/* SD1 */
> diff --git a/arch/arm/mach-mx5/devices-mx50.h b/arch/arm/mach-mx5/devices-imx50.h
> similarity index 100%
> rename from arch/arm/mach-mx5/devices-mx50.h
> rename to arch/arm/mach-mx5/devices-imx50.h
> --
> 1.7.0.4
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-10 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 21:44 [PATCH 1/1] ARM i.MX50: Rename devices-mx50.h Jason Liu
2011-01-10 22:31 ` Uwe Kleine-König
2011-01-10 23:52 ` Richard Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox