From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: tegra: don't treat NULL clk as an error
Date: Mon, 10 Jan 2011 16:43:21 -0700 [thread overview]
Message-ID: <20110110234321.GA1846@angua.secretlab.ca> (raw)
In-Reply-To: <20110110233033.GG12552@n2100.arm.linux.org.uk>
On Mon, Jan 10, 2011 at 11:30:33PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 10, 2011 at 04:24:17PM -0700, Grant Likely wrote:
> > I was actually looking at the implementation of clk_enable() which is
> > called by the driver and doesn't do any NULL checking. But I suppose
> > that it then becomes the clock-code's own fault if it returns NULL and
> > then oopses on a NULL being passed to it. Okay, I'll apply it.
>
> Yes absolutely. The clk API must eat whatever cookies it produces,
> even if they contain dead flies rather than currants. ;)
nice analogy. :-)
g.
prev parent reply other threads:[~2011-01-10 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 11:05 [PATCH] spi: tegra: don't treat NULL clk as an error Jamie Iles
2011-01-10 20:58 ` Grant Likely
2011-01-10 22:18 ` Russell King - ARM Linux
2011-01-10 22:25 ` Russell King - ARM Linux
2011-01-10 23:24 ` Grant Likely
2011-01-10 23:30 ` Russell King - ARM Linux
2011-01-10 23:43 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110234321.GA1846@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox