From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial: Add auart driver for i.MX23/28
Date: Tue, 11 Jan 2011 18:57:04 +0100 [thread overview]
Message-ID: <20110111175704.GV12078@pengutronix.de> (raw)
In-Reply-To: <20110111171050.GA522@pengutronix.de>
On Tue, Jan 11, 2011 at 06:10:50PM +0100, Wolfram Sang wrote:
> On Tue, Jan 11, 2011 at 04:09:04PM +0100, Sascha Hauer wrote:
> [...]
> > +#include <asm/cacheflush.h>
> > +#include <mach/mx28.h>
>
> What about MX23 and STMP3xxx?
This include is not needed, will remove. Instead we need linux/io.h.
>
> > +
> > +#define MXS_AUART_PORTS 5
>
> MX23 has just 2. We should better adapt to that depending on the type?
This is just the maximum number the driver supports, it's safe to keep
it as is.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-01-11 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 15:09 Add i.MX23/28 auart support Sascha Hauer
2011-01-11 15:09 ` [PATCH 1/2] serial: Add auart driver for i.MX23/28 Sascha Hauer
2011-01-11 16:05 ` Russell King - ARM Linux
2011-01-11 17:10 ` Wolfram Sang
2011-01-11 17:57 ` Sascha Hauer [this message]
2011-01-12 5:39 ` Shawn Guo
2011-01-11 15:09 ` [PATCH 2/2] ARM i.MXS: Add auart platform support for i.MX28 Sascha Hauer
2011-01-11 15:17 ` Uwe Kleine-König
2011-01-11 15:26 ` Sascha Hauer
2011-01-12 5:06 ` Shawn Guo
2011-01-12 6:17 ` Shawn Guo
2011-01-12 5:31 ` Add i.MX23/28 auart support Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2011-01-13 13:14 [PATCH v2] " Sascha Hauer
2011-01-13 13:14 ` [PATCH 1/2] serial: Add auart driver for i.MX23/28 Sascha Hauer
2011-01-24 10:03 [PATCH v3] Add i.MX23/28 auart support Sascha Hauer
2011-01-24 10:03 ` [PATCH 1/2] serial: Add auart driver for i.MX23/28 Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111175704.GV12078@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).