From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
Date: Wed, 12 Jan 2011 10:32:46 +0100 [thread overview]
Message-ID: <20110112093246.GA25718@pengutronix.de> (raw)
In-Reply-To: <20110112091716.GU11039@n2100.arm.linux.org.uk>
Hello Russell,
On Wed, Jan 12, 2011 at 09:17:16AM +0000, Russell King - ARM Linux wrote:
> > Does it make sense at all to disable CONFIG_CMDLINE_FORCE? If not, I
> > suggest to remove it.
>
> Eeh? Do you understand what CONFIG_CMDLINE_FORCE is and what effect it
> has?
>
> When CONFIG_CMDLINE_FORCE is enabled, we ignore the command line passed
> in from the boot loader and always use the built-in command line. When
> CONFIG_CMDLINE_FORCE is disabled, we will use the boot loader supplied
> command line if present.
>
> "Does it make sense at all to disable CONFIG_CMDLINE_FORCE" so, if you
> always have it enabled, you can never pass in a command line from a boot
> loader. That's an absolutely idiotic idea.
>
> _Most_ of us want to pass in command lines from the boot loader so we can
> configure things.
ah, I thought the effect of CONFIG_CMDLINE_FORCE would be its inverse.
And ok, this is probably about broken boot loaders that I'm just not
used to.
> Please, if you don't understand, ask questions rather than making
> completely misleading review comments which may confuse patch submitters.
IMHO "Does it make sense at all to disable CONFIG_CMDLINE_FORCE?" is a
question, isn't it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-01-12 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 23:45 [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used Alexander Holler
2011-01-12 8:11 ` Uwe Kleine-König
2011-01-12 9:17 ` Russell King - ARM Linux
2011-01-12 9:32 ` Uwe Kleine-König [this message]
2011-01-12 12:42 ` Alexander Holler
2011-01-12 9:19 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112093246.GA25718@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).