From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: i.MX53 EVK: add spi device
Date: Wed, 12 Jan 2011 11:42:00 +0100 [thread overview]
Message-ID: <20110112104200.GG24920@pengutronix.de> (raw)
In-Reply-To: <AANLkTimFGB1BysGiQhgpc9Dq=6t8JYdeKDY_iR1=HzO7@mail.gmail.com>
On Wed, Jan 12, 2011 at 06:10:26PM +0800, Yong Shen wrote:
> Hi Uwe,
>
> >> + ? ? MX53_PAD_EIM_D16__CSPI1_SCLK,
> >> + ? ? MX53_PAD_EIM_D17__CSPI1_MISO,
> >> + ? ? MX53_PAD_EIM_D18__CSPI1_MOSI,
> > did the v2 patch work at all?
>
> Yes, it did work. Only the pad names were wrong, the configurations
> were right, so v3 changed the names to match the configuration.
you didn't just rename the defines but really changed them. (Which
might or might not mean something.):
> -#define MX53_PAD_EIM_D16__GPIO_3_16 IOMUX_PAD(0x460, 0x118,IOMUX_CONFIG_ALT1, 0x0, 0, NO_PAD_CTRL)
> -#define MX53_PAD_EIM_D17__GPIO_3_17 IOMUX_PAD(0x464, 0x11C,IOMUX_CONFIG_ALT1, 0x0, 0, NO_PAD_CTRL)
> -#define MX53_PAD_EIM_D18__GPIO_3_18 IOMUX_PAD(0x468, 0x120,IOMUX_CONFIG_ALT1, 0x0, 0, NO_PAD_CTRL)
> +#define MX53_PAD_EIM_D16__CSPI1_SCLK IOMUX_PAD(0x460, 0x118,IOMUX_CONFIG_ALT4, 0x79c, 3, NO_PAD_CTRL)
> +#define MX53_PAD_EIM_D17__CSPI1_MISO IOMUX_PAD(0x464, 0x11C,IOMUX_CONFIG_ALT4, 0x7a0, 3, NO_PAD_CTRL)
> +#define MX53_PAD_EIM_D18__CSPI1_MOSI IOMUX_PAD(0x468, 0x120,IOMUX_CONFIG_ALT4, 0x7a4, 3, NO_PAD_CTRL)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-01-12 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 8:35 [PATCH v3 0/4] ARM: i.MX53: spi related patches yong.shen at freescale.com
2011-01-12 8:35 ` [PATCH v3 1/4] ARM: i.MX53: enable spi support yong.shen at freescale.com
2011-01-12 9:37 ` Uwe Kleine-König
2011-01-12 10:03 ` Yong Shen
2011-01-12 10:16 ` Uwe Kleine-König
2011-01-12 10:40 ` Yong Shen
2011-01-12 8:35 ` [PATCH v3 2/4] ARM: i.MX53 EVK: add spi device yong.shen at freescale.com
2011-01-12 9:40 ` Uwe Kleine-König
2011-01-12 10:10 ` Yong Shen
2011-01-12 10:42 ` Uwe Kleine-König [this message]
2011-01-12 8:35 ` [PATCH v3 3/4] ARM: i.MX53 EVK: add spi nor device yong.shen at freescale.com
2011-01-12 8:35 ` [PATCH v3 4/4] ARM: i.MX5: uart clock bug fix yong.shen at freescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112104200.GG24920@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox