From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] unbreak ehci-mxc on otg port of i.MX27
Date: Thu, 13 Jan 2011 10:12:29 +0100 [thread overview]
Message-ID: <20110113091229.GE12078@pengutronix.de> (raw)
In-Reply-To: <1294909575-32709-1-git-send-email-eric@eukrea.com>
On Thu, Jan 13, 2011 at 10:06:15AM +0100, Eric B?nard wrote:
> commit 711669e5b80b6f2d88f61ed8a9681f83d8cbd201 fixed port 0 support
> for i.MX51 but broke it for (at least) i.MX27 which doesn't have
> a usb_phy1 clock but has a pdev->id 0.
Shame on me for not reviewing the patch properly :(
>
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/usb/host/ehci-mxc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index fa59b26..18eb597 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -178,7 +178,7 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> }
>
> /* "dr" device has its own clock */
> - if (pdev->id == 0) {
> + if ((cpu_is_mx51()) & (pdev->id == 0)) {
should be && and please remove the unnecessary braces around
cpu_is_mx51(). Otherwise ok.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-01-13 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 9:06 [PATCH] unbreak ehci-mxc on otg port of i.MX27 Eric Bénard
2011-01-13 9:12 ` Sascha Hauer [this message]
2011-01-13 9:17 ` Eric Bénard
2011-01-13 13:53 ` [PATCH v2] " Eric Bénard
2011-01-13 17:48 ` Sergei Shtylyov
2011-01-13 18:02 ` Greg KH
2011-01-13 10:48 ` [PATCH] " Arnaud Patard (Rtp)
2011-01-13 12:17 ` Sergei Shtylyov
2011-01-13 12:22 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113091229.GE12078@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).