From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure)
Date: Thu, 13 Jan 2011 09:15:46 +0000 [thread overview]
Message-ID: <20110113091546.GA24429@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <2f1a86cfda277de8d190e5eb9b9ccd77@mail.gmail.com>
On Thu, Jan 13, 2011 at 02:22:06PM +0530, Anand Gadiyar wrote:
> Tony Lindgren wrote:
> > /* Power on the ULPI PHY */
> > - if (gpio_is_valid(OMAP4SDP_MDM_PWR_EN_GPIO)) {
> > - /* FIXME: Assumes pad is already muxed for GPIO mode */
> > - gpio_request(OMAP4SDP_MDM_PWR_EN_GPIO, "USBB1 PHY
> VMDM_3V3");
> > + status = gpio_request(OMAP4SDP_MDM_PWR_EN_GPIO, "USBB1 PHY
> VMDM_3V3");
> > + if (status)
> > + pr_err("%s: Could not get USBB1 PHY GPIO\n");
>
> Tony,
>
> This throws up a build warning as there's no parameter corresponding to
> the %s. Showed up in linux-next as of today.
It's pretty obvious that the above is wrong, and the compiler would
have caught it with a warning when building it. Was the above patch
not build-tested before it was committed?
Given the very sorry state of OMAP in mainline at present, I'm surprised
that this kind of stuff is still going on...
next prev parent reply other threads:[~2011-01-13 9:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110106170805.GE1198@n2100.arm.linux.org.uk>
[not found] ` <20110106180030.GA8249@n2100.arm.linux.org.uk>
[not found] ` <20110106182023.GV7771@atomide.com>
[not found] ` <20110106203238.GH1198@n2100.arm.linux.org.uk>
[not found] ` <20110106204053.GA7771@atomide.com>
[not found] ` <20110107161230.GR1198@n2100.arm.linux.org.uk>
[not found] ` <20110110185209.GC4957@atomide.com>
2011-01-11 23:16 ` [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure) Tony Lindgren
2011-01-13 8:52 ` Anand Gadiyar
2011-01-13 9:15 ` Russell King - ARM Linux [this message]
2011-01-13 15:51 ` Tony Lindgren
2011-01-13 16:49 ` Russell King - ARM Linux
2011-01-14 17:29 ` Tony Lindgren
2011-01-14 19:18 ` Paul Walmsley
2011-01-14 21:20 ` Russell King - ARM Linux
2011-01-14 22:07 ` Paul Walmsley
2011-01-14 23:10 ` Paul Walmsley
2011-01-14 23:58 ` Russell King - ARM Linux
2011-01-15 0:12 ` Tony Lindgren
2011-01-15 0:25 ` Russell King - ARM Linux
2011-01-15 0:37 ` Tony Lindgren
2011-01-15 17:04 ` Russell King - ARM Linux
2011-01-17 8:35 ` Sascha Hauer
2011-02-01 12:55 ` Anand Gadiyar
2011-02-02 1:10 ` Tony Lindgren
2011-02-02 6:05 ` Santosh Shilimkar
2011-02-02 19:48 ` Tony Lindgren
2011-02-03 8:43 ` Santosh Shilimkar
2011-02-12 8:46 ` Santosh Shilimkar
2011-02-24 17:38 ` Tony Lindgren
2011-02-25 5:33 ` Santosh Shilimkar
2011-02-25 17:49 ` Tony Lindgren
2011-02-02 18:43 ` Anand Gadiyar
2011-02-02 19:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113091546.GA24429@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).