From mboxrd@z Thu Jan  1 00:00:00 1970
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
Date: Mon, 17 Jan 2011 08:50:12 +0000
Subject: [PATCH 27/48] ARM: PL08x: avoid duplicating registers in txd
	and phychan structures
In-Reply-To: <AANLkTikC7gewBjB_5ebi11J_Brpoc6p=3bWLb=8WdUk_@mail.gmail.com>
References: <E1PZt3Z-00025W-0c@rmk-PC.arm.linux.org.uk>
	<AANLkTi=GsMaDQDSuR=Z4AT4Vk4GThx6O_0Le=pjsu9gj@mail.gmail.com>
	<20110115092324.GX15996@n2100.arm.linux.org.uk>
	<AANLkTim_1yK_Q7sy4a1iMX2zXG1p3EJ0avGvcYeTP9Us@mail.gmail.com>
	<20110116123615.GC27542@n2100.arm.linux.org.uk>
	<AANLkTi=s-CQVEj4wOZo8cCbzWnj5G0p_COtKoQt7Xzy8@mail.gmail.com>
	<20110116195948.GA4864@n2100.arm.linux.org.uk>
	<4D334F15.3080705@intel.com>
	<20110116201805.GB4864@n2100.arm.linux.org.uk>
	<AANLkTikC7gewBjB_5ebi11J_Brpoc6p=3bWLb=8WdUk_@mail.gmail.com>
Message-ID: <20110117085012.GA17036@n2100.arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Sun, Jan 16, 2011 at 05:36:57PM -0800, Dan Williams wrote:
> On Sun, Jan 16, 2011 at 12:18 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Subject: [PATCH] ARM: PL08x: cleanup comments
> >
> > Cleanup the formatting of comments, remove some which don't make sense
> > anymore.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > ?drivers/dma/amba-pl08x.c ? | ?144 ++++++++++++++++----------------------------
> > ?include/linux/amba/pl08x.h | ? 45 +++++++-------
> > ?2 files changed, 72 insertions(+), 117 deletions(-)
> >
> [..]
> > diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h
> > index 933b4ed..3111385 100644
> > --- a/include/linux/amba/pl08x.h
> > +++ b/include/linux/amba/pl08x.h
> [..]
> 
> Thanks, applied after changing the following hunk...
> 
> > @@ -118,8 +116,7 @@ struct pl08x_txd {
> > ? ? ? ?dma_addr_t dst_addr;
> > ? ? ? ?size_t len;
> > ? ? ? ?dma_addr_t llis_bus;
> > - ? ? ? void *llis_va;
> > - ? ? ? bool active;
> > + ? ? ? struct pl08x_lli *llis_va;
> > ? ? ? ?/* Default cctl value for LLIs */
> > ? ? ? ?u32 cctl;
> > ? ? ? ?/*
> 
> ...to:
> 
> @@ -119,7 +117,6 @@ struct pl08x_txd {
>         size_t len;
>         dma_addr_t llis_bus;
>         struct pl08x_lli *llis_va;
> -       bool active;
>         /* Default cctl value for LLIs */
>         u32 cctl;
>         /*

Sigh - but that was the original problem which was complained about -
llis_va was void pointer not a struct.

So what was the point of asking me for some random patch again?

I'm confused.