From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dmaengine: imx-sdma: fix return of sdma_probe()
Date: Mon, 17 Jan 2011 19:28:30 +0100 [thread overview]
Message-ID: <20110117182830.GU6917@pengutronix.de> (raw)
In-Reply-To: <1295275164-7824-2-git-send-email-shawn.guo@freescale.com>
If you make the commit log read something like:
dmaengine: imx-sdma: propagate error in sdma_probe instead of returning 0
you can have my ack.
Uwe
On Mon, Jan 17, 2011 at 10:39:23PM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> drivers/dma/imx-sdma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index d5a5d4d..48d0197 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1348,7 +1348,7 @@ err_clk:
> err_request_region:
> err_irq:
> kfree(sdma);
> - return 0;
> + return ret;
> }
>
> static int __exit sdma_remove(struct platform_device *pdev)
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-01-17 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 14:39 A couple of trivial fix on imx-sdma Shawn Guo
2011-01-17 14:39 ` [PATCH 1/2] dmaengine: imx-sdma: fix return of sdma_probe() Shawn Guo
2011-01-17 18:28 ` Uwe Kleine-König [this message]
2011-01-17 14:39 ` [PATCH 2/2] dmaengine: imx-sdma: fix inconsistent naming in sdma_assign_cookie() Shawn Guo
2011-01-30 6:20 ` Dan Williams
2011-01-17 14:47 ` A couple of trivial fix on imx-sdma Sascha Hauer
2011-01-19 11:13 ` [PATCH v2 1/2] dmaengine: imx-sdma: propagate error in sdma_probe() instead of returning 0 Shawn Guo
2011-01-19 7:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117182830.GU6917@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).