linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: State of LDP3430 platform
Date: Mon, 17 Jan 2011 17:25:42 -0800	[thread overview]
Message-ID: <20110118012541.GN4957@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101152028580.13225@utopia.booyaka.com>

Hi,

* Paul Walmsley <paul@pwsan.com> [110115 20:31]:
> --- a/arch/arm/mach-omap1/time.c
> +++ b/arch/arm/mach-omap1/time.c
> @@ -244,6 +244,13 @@ static void __init omap_timer_init(void)
>  
>  	omap_init_mpu_timer(rate);
>  	omap_init_clocksource(rate);
> +	/*
> +	 * XXX Since this file seems to deal mostly with the MPU timer,
> +	 * this doesn't seem like the correct place for the sync timer
> +	 * clocksource init.
> +	 */
> +	if (!cpu_is_omap7xx() && !cpu_is_omap15xx())
> +		omap_init_clocksource_32k();
>  }
>  
>  struct sys_timer omap_timer = {

To me it looks like the omap_init_clocksource_32k() call should be
in arch/arm/mach-omap1/timer32k.c instead.

Regards,

Tony

  parent reply	other threads:[~2011-01-18  1:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20101206125526.GC31777@n2100.arm.linux.org.uk>
     [not found] ` <20101206181913.GH8345@atomide.com>
     [not found]   ` <alpine.DEB.2.00.1012061125400.13430@utopia.booyaka.com>
     [not found]     ` <20101207083720.GB18336@n2100.arm.linux.org.uk>
     [not found]       ` <alpine.DEB.2.00.1012071745120.13430@utopia.booyaka.com>
     [not found]         ` <alpine.DEB.2.00.1012072012000.13430@utopia.booyaka.com>
     [not found]           ` <20110115000301.GT4957@atomide.com>
     [not found]             ` <alpine.DEB.2.00.1101151237240.32245@utopia.booyaka.com>
     [not found]               ` <20110115233744.GA18159@n2100.arm.linux.org.uk>
2011-01-16  4:32                 ` State of LDP3430 platform Paul Walmsley
2011-01-16 15:08                   ` Thomas Weber
2011-01-18 19:36                     ` Paul Walmsley
2011-01-18 22:26                       ` [PATCH] omap1: Fix sched_clock for the MPU timer (Re: State of LDP3430 platform) Tony Lindgren
2011-01-18 22:35                         ` [PATCH] omap1: Fix booting for 15xx and 730 with omap1_defconfig " Tony Lindgren
2011-01-18 23:21                           ` Tony Lindgren
2011-01-19 18:43                             ` [PATCH] omap1: Fix sched_clock implementation when both MPU timer and 32K timer are used " Tony Lindgren
2011-01-19 18:44                         ` [PATCH] omap1: Fix sched_clock for the MPU timer " Tony Lindgren
2011-01-19 13:43                       ` State of LDP3430 platform Jarkko Nikula
2011-01-18  1:25                   ` Tony Lindgren [this message]
2011-01-18 19:24                     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110118012541.GN4957@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).