From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030
Date: Tue, 18 Jan 2011 05:10:39 +0200 [thread overview]
Message-ID: <20110118031038.GA2436@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1295299548-22839-1-git-send-email-bgamari.foss@gmail.com>
Hi,
On Mon, Jan 17, 2011 at 04:25:48PM -0500, Ben Gamari wrote:
> Some very basic setup (i.e. MMC) is done in the beagleboard's setup
> callback for the TWL4030's gpio driver, causing a kernel without this
> support to fail to find its root filesystem. I can't imagine why one would
> want to build a kernel for this board without this driver, so I think
> it's worthwhile to explicitly depend on it.
>
> Signed-Off-By: Ben Gamari <bgamari.foss@gmail.com>
> ---
> arch/arm/mach-omap2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index ab784bf..74173f1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -120,6 +120,7 @@ config MACH_OMAP_2430SDP
> config MACH_OMAP3_BEAGLE
> bool "OMAP3 BEAGLE board"
> depends on ARCH_OMAP3
> + depends on GPIO_TWL4030
> default y
> select OMAP_PACKAGE_CBB
NAK. This is totally bogus. The board doesn't really depend on
GPIO_TWL4030, the MMC driver does.
--
balbi
next prev parent reply other threads:[~2011-01-18 3:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 21:25 [PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030 Ben Gamari
2011-01-18 3:10 ` Felipe Balbi [this message]
2011-01-18 13:51 ` Ben Gamari
2011-01-19 3:45 ` Felipe Balbi
2011-01-19 20:04 ` Ben Gamari
2011-01-20 4:08 ` Felipe Balbi
2011-01-20 17:27 ` Tony Lindgren
2011-01-20 21:44 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118031038.GA2436@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).