From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: use fncpy to copy the PM code functions to SRAM
Date: Tue, 18 Jan 2011 15:44:43 -0800 [thread overview]
Message-ID: <20110118234443.GV4957@atomide.com> (raw)
In-Reply-To: <20110118234215.GB17398@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [110118 15:41]:
> On Tue, Jan 18, 2011 at 01:05:49PM +0100, Jean Pihet wrote:
> > Dave, Russell,
> >
> > On Mon, Jan 17, 2011 at 4:46 PM, Dave Martin <dave.martin@linaro.org> wrote:
> > > One way to work around this is would be to make omap_sram_push() a macro:
> > >
> > > #define omap_sram_push(funcp, size) \
> > > ? ?(typeof(funcp))_do_omap_sram_push((void *)(funcp), size)
> > >
> > > ... where the definition of _do_omap_sram_push() is the same is the
> > > existing definition of omap_sram_push(). ?Providing
> > > _do_omap_sram_push() is not called directly, this should now be
> > > type-safe.
> > >
> > Ok I reworked the patch from your suggestions. Indeed a few functions
> > types mismatch have been spotted and corrected using the fncpy API.
> >
> > New patch sent as '[PATCH v2] OMAP: use fncpy to copy the PM code
> > functions to SRAM'.
>
> Looks good, thanks. Next problem to sort out is who's taking the
> patches...
You can take them but we should have at least Kevin test and ack them.
Tony
next prev parent reply other threads:[~2011-01-18 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 15:21 [PATCH] OMAP: use fncpy to copy the PM code functions to SRAM jean.pihet at newoldbits.com
2011-01-14 15:23 ` Jean Pihet
2011-01-14 15:58 ` Russell King - ARM Linux
2011-01-14 16:13 ` Jean Pihet
2011-01-14 17:34 ` Russell King - ARM Linux
2011-01-17 14:01 ` Jean Pihet
2011-01-17 15:46 ` Dave Martin
2011-01-18 12:05 ` Jean Pihet
2011-01-18 23:42 ` Russell King - ARM Linux
2011-01-18 23:44 ` Tony Lindgren [this message]
2011-01-19 8:06 ` Jean Pihet
2011-01-19 19:10 ` Tony Lindgren
2011-01-19 21:37 ` Jean Pihet
2011-01-19 21:44 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2011-02-02 14:45 [PATCH] omap: " jean.pihet at newoldbits.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118234443.GV4957@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).