From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] dmaengine: imx-sdma: fix up param for the last BD in sdma_prep_slave_sg()
Date: Fri, 21 Jan 2011 22:45:30 +0800 [thread overview]
Message-ID: <20110121144528.GA13825@freescale.com> (raw)
In-Reply-To: <20110121102424.GB9041@pengutronix.de>
Hi Sascha,
On Fri, Jan 21, 2011 at 11:24:24AM +0100, Sascha Hauer wrote:
> On Fri, Jan 21, 2011 at 11:15:39PM +0800, Shawn Guo wrote:
> > Hi Sascha,
> >
> > On Thu, Jan 20, 2011 at 11:28:08AM +0100, Sascha Hauer wrote:
> > > On Thu, Jan 20, 2011 at 05:50:39AM +0800, Shawn Guo wrote:
> > > > As per the reference manual, bit "L" should be set while bit "C"
> > > > should be cleared for the last buffer descriptor in the non-cyclic
> > > > chain, so that sdma can stop trying to find the next BD and end
> > > > the transfer.
> > > >
> > > > In case of sdma_prep_slave_sg(), BD_LAST needs to be set and BD_CONT
> > > > be cleared for the last BD.
> > >
> > > Did you test this patch?
> > >
> > Would you suggest any driver on mx51 using this api? So that I can
> > test it on my babbage board. Or you can help test it with mx27/31
> > mmc driver? I do not have them on my end. Thanks.
>
> I can only suggest the imx/imx-sdma-sound-mx353ds-mx51_babbage
> branch, but this only uses cyclic transfers so you can't use it
> to test this patch.
Yes, I tested the patch set against imx/imx-sdma-sound-mx353ds-mx51_babbage.
But the only use of sdma_prep_slave_sg I know is mxcmmc.c that you
patched recently. And this driver is for mx27/31 which I do not have
the setup.
> I asked because I could add an ack to this patch if it has been
> tested. Without testing I'd like delaying it until I found some
> time testing it.
Reasonable. Thanks.
--
Regards,
Shawn
next prev parent reply other threads:[~2011-01-21 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 21:50 [PATCH 0/6] A few fixes on imx-sdma Shawn Guo
2011-01-19 21:50 ` [PATCH 1/6] dmaengine: imx-sdma: remove IMX_DMA_SG_LOOP handling in sdma_prep_slave_sg() Shawn Guo
2011-01-19 21:50 ` [PATCH 2/6] dmaengine: imx-sdma: set sdmac->status to DMA_ERROR in err_out of sdma_prep_slave_sg() Shawn Guo
2011-01-19 21:50 ` [PATCH 3/6] dmaengine: imx-sdma: return sdmac->status in sdma_tx_status() Shawn Guo
2011-01-19 21:50 ` [PATCH 4/6] dmaengine: imxs-sdma: correct sdmac->status in sdma_handle_channel_loop() Shawn Guo
2011-01-19 21:50 ` [PATCH 5/6] dmaengine: imx-sdma: fix up param for the last BD in sdma_prep_slave_sg() Shawn Guo
2011-01-20 10:28 ` Sascha Hauer
2011-01-21 15:15 ` Shawn Guo
2011-01-21 10:24 ` Sascha Hauer
2011-01-21 14:45 ` Shawn Guo [this message]
2011-01-19 21:50 ` [PATCH 6/6] dmaengine: imx-sdma: avoid stopping channel in the middle of a BD transfer Shawn Guo
2011-01-20 10:43 ` Shawn Guo
2011-01-20 10:27 ` Sascha Hauer
2011-01-21 15:55 ` Shawn Guo
2011-01-21 9:45 ` Sascha Hauer
2011-01-21 14:53 ` Shawn Guo
2011-01-20 8:56 ` [PATCH 0/6] A few fixes on imx-sdma Shawn Guo
2011-01-31 12:03 ` Sascha Hauer
2011-02-14 10:26 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121144528.GA13825@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).