* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
@ 2011-01-20 17:02 Fabio Estevam
2011-01-21 10:35 ` Sascha Hauer
2011-01-21 15:33 ` Uwe Kleine-König
0 siblings, 2 replies; 7+ messages in thread
From: Fabio Estevam @ 2011-01-20 17:02 UTC (permalink / raw)
To: linux-arm-kernel
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index d618e86..a3a9ec1 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -288,7 +288,7 @@ config MMC_MSM
config MMC_MXC
tristate "Freescale i.MX2/3 Multimedia Card Interface support"
- depends on ARCH_MXC
+ depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
help
This selects the Freescale i.MX2/3 Multimedia card Interface.
If you have a i.MX platform with a Multimedia Card slot,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-01-20 17:02 [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms Fabio Estevam
@ 2011-01-21 10:35 ` Sascha Hauer
2011-02-09 0:40 ` Estevam Fabio-R49496
2011-01-21 15:33 ` Uwe Kleine-König
1 sibling, 1 reply; 7+ messages in thread
From: Sascha Hauer @ 2011-01-21 10:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
> Currently MMC_MXC driver can be selected by all i.MX devices.
>
> Restrict its use only for the appropriate processors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index d618e86..a3a9ec1 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -288,7 +288,7 @@ config MMC_MSM
>
> config MMC_MXC
> tristate "Freescale i.MX2/3 Multimedia Card Interface support"
> - depends on ARCH_MXC
> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
> help
> This selects the Freescale i.MX2/3 Multimedia card Interface.
> If you have a i.MX platform with a Multimedia Card slot,
> --
> 1.6.0.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-01-21 10:35 ` Sascha Hauer
@ 2011-02-09 0:40 ` Estevam Fabio-R49496
2011-02-09 0:54 ` Chris Ball
0 siblings, 1 reply; 7+ messages in thread
From: Estevam Fabio-R49496 @ 2011-02-09 0:40 UTC (permalink / raw)
To: linux-arm-kernel
Chris?
-----Original Message-----
From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
Sent: Friday, January 21, 2011 8:35 AM
To: Estevam Fabio-R49496
Cc: linux-mmc at vger.kernel.org; cjb at laptop.org; kernel at pengutronix.de; u.kleine-koenig at pengutronix.de; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
> Currently MMC_MXC driver can be selected by all i.MX devices.
>
> Restrict its use only for the appropriate processors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index
> d618e86..a3a9ec1 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -288,7 +288,7 @@ config MMC_MSM
>
> config MMC_MXC
> tristate "Freescale i.MX2/3 Multimedia Card Interface support"
> - depends on ARCH_MXC
> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
> help
> This selects the Freescale i.MX2/3 Multimedia card Interface.
> If you have a i.MX platform with a Multimedia Card slot,
> --
> 1.6.0.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-02-09 0:40 ` Estevam Fabio-R49496
@ 2011-02-09 0:54 ` Chris Ball
0 siblings, 0 replies; 7+ messages in thread
From: Chris Ball @ 2011-02-09 0:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio,
On Wed, Feb 09, 2011 at 12:40:51AM +0000, Estevam Fabio-R49496 wrote:
> On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
> > Currently MMC_MXC driver can be selected by all i.MX devices.
> >
> > Restrict its use only for the appropriate processors.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Thanks for the ping -- I've pushed this to mmc-next with Sascha's ACK now.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-01-20 17:02 [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms Fabio Estevam
2011-01-21 10:35 ` Sascha Hauer
@ 2011-01-21 15:33 ` Uwe Kleine-König
2011-01-21 16:11 ` Fabio Estevam
1 sibling, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2011-01-21 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Hallo,
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
> Currently MMC_MXC driver can be selected by all i.MX devices.
>
> Restrict its use only for the appropriate processors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index d618e86..a3a9ec1 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -288,7 +288,7 @@ config MMC_MSM
>
> config MMC_MXC
> tristate "Freescale i.MX2/3 Multimedia Card Interface support"
> - depends on ARCH_MXC
> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
What about
depends IMX_HAVE_PLATFORM_MXC_MMC
? Then if i.MX29 has the same IP you don't need to touch this again.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-01-21 15:33 ` Uwe Kleine-König
@ 2011-01-21 16:11 ` Fabio Estevam
2011-01-21 19:32 ` Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2011-01-21 16:11 UTC (permalink / raw)
To: linux-arm-kernel
Hi Uwe,
On 1/21/2011 1:33 PM, Uwe Kleine-K?nig wrote:
> Hallo,
>
> On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
>> Currently MMC_MXC driver can be selected by all i.MX devices.
>>
>> Restrict its use only for the appropriate processors.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> drivers/mmc/host/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index d618e86..a3a9ec1 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -288,7 +288,7 @@ config MMC_MSM
>>
>> config MMC_MXC
>> tristate "Freescale i.MX2/3 Multimedia Card Interface support"
>> - depends on ARCH_MXC
>> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
> What about
>
> depends IMX_HAVE_PLATFORM_MXC_MMC
I would prefer to let the architectures explicitly in Kconfig.
If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51 board, it will be possible to select the MXC_MMC driver in the kernel for MX51, which is incorrect.
Using the approach of explicitly marking the architectures that support MXC_MMC would avoid such problems as well.
>
> ? Then if i.MX29 has the same IP you don't need to touch this again.
Not likely to happen.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
2011-01-21 16:11 ` Fabio Estevam
@ 2011-01-21 19:32 ` Uwe Kleine-König
0 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2011-01-21 19:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello Fabio,
On Fri, Jan 21, 2011 at 02:11:46PM -0200, Fabio Estevam wrote:
> On 1/21/2011 1:33 PM, Uwe Kleine-K?nig wrote:
> > On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
> >> Currently MMC_MXC driver can be selected by all i.MX devices.
> >>
> >> Restrict its use only for the appropriate processors.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> ---
> >> drivers/mmc/host/Kconfig | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >> index d618e86..a3a9ec1 100644
> >> --- a/drivers/mmc/host/Kconfig
> >> +++ b/drivers/mmc/host/Kconfig
> >> @@ -288,7 +288,7 @@ config MMC_MSM
> >>
> >> config MMC_MXC
> >> tristate "Freescale i.MX2/3 Multimedia Card Interface support"
> >> - depends on ARCH_MXC
> >> + depends on MACH_MX21 || MACH_MX27 || ARCH_MX31
> > What about
> >
> > depends IMX_HAVE_PLATFORM_MXC_MMC
>
> I would prefer to let the architectures explicitly in Kconfig.
>
> If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51
> board, it will be possible to select the MXC_MMC driver in the kernel
> for MX51, which is incorrect.
it's not optimal, but nothing happens unless this someone registers a
corresponding device, too.
> Using the approach of explicitly marking the architectures that
> support MXC_MMC would avoid such problems as well.
> >
> > ? Then if i.MX29 has the same IP you don't need to touch this again.
>
> Not likely to happen.
I wouldn't bet ...
Note I don't argue, if you still prefer the explicit list it's OK for
me.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-09 0:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-20 17:02 [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms Fabio Estevam
2011-01-21 10:35 ` Sascha Hauer
2011-02-09 0:40 ` Estevam Fabio-R49496
2011-02-09 0:54 ` Chris Ball
2011-01-21 15:33 ` Uwe Kleine-König
2011-01-21 16:11 ` Fabio Estevam
2011-01-21 19:32 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).