linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc
Date: Fri, 21 Jan 2011 10:40:21 -0800	[thread overview]
Message-ID: <20110121184020.GD11678@atomide.com> (raw)
In-Reply-To: <1295443503-14515-4-git-send-email-s-ghorai@ti.com>

* Sukumar Ghorai <s-ghorai@ti.com> [110119 05:24]:
> add support the irq mode in GPMC.
> gpmc_init() function move after omap_init_irq() as it has dependecy on irq.
> 
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> index e066177..527374f 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -146,6 +146,7 @@ static void __init omap_2430sdp_init_irq(void)
>  	omap2_init_common_infrastructure();
>  	omap2_init_common_devices(NULL, NULL);
>  	omap_init_irq();
> +	gpmc_init();
>  }
>  
>  static struct twl4030_gpio_platform_data sdp2430_gpio_data = {
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 8fb5f43..8304d16 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -335,6 +335,7 @@ static void __init omap_3430sdp_init_irq(void)
>  	omap2_init_common_infrastructure();
>  	omap2_init_common_devices(hyb18m512160af6_sdrc_params, NULL);
>  	omap_init_irq();
> +	gpmc_init();
>  }
...

I think I've commented on this before, but why don't you make gpmc_init
a subsys_initcall? There should be no reason to call this earlier.
If something does not work because of that, then that issue must be
fixed.

Tony

  reply	other threads:[~2011-01-21 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 13:24 [PATCH RESEND v8 0/7] nand prefetch-irq support and ecc layout chanage Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 1/7] omap3630: nand: fix device size to work in polled mode Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 2/7] omap3: nand: configurable transfer type per board Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc Sukumar Ghorai
2011-01-21 18:40   ` Tony Lindgren [this message]
2011-01-22 17:54     ` Ghorai, Sukumar
2011-01-25 16:57       ` Tony Lindgren
2011-01-28  8:15         ` Ghorai, Sukumar
2011-01-28 16:51           ` Tony Lindgren
2011-01-19 13:25 ` [PATCH RESEND v8 5/7] omap3: nand: configurable fifo threshold to gain the throughput Sukumar Ghorai
2011-01-19 13:25 ` [PATCH RESEND v8 6/7] omap3: nand: ecc layout select from board file Sukumar Ghorai
2011-01-19 13:25 ` [PATCH RESEND v8 7/7] omap3: nand: making ecc layout as compatible with romcode ecc Sukumar Ghorai
2011-07-08 17:38 ` [PATCH RESEND v8 4/7] omap3: nand: prefetch in irq mode support Sukumar Ghorai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110121184020.GD11678@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).