From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Support BE8 mode kernel modules relocation
Date: Sat, 22 Jan 2011 17:00:44 +0000 [thread overview]
Message-ID: <20110122170044.GA12982@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D395BE1.2050806@windriver.com>
On Fri, Jan 21, 2011 at 06:11:45PM +0800, stanley.miao wrote:
> Russell King - ARM Linux wrote:
>> On Wed, Jan 19, 2011 at 02:44:45PM +0800, Stanley.Miao wrote:
>>
>>> @@ -174,9 +186,9 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
>>> * other bits to re-code instruction as
>>> * MOV PC,Rm.
>>> */
>>> - *(u32 *)loc &= 0xf000000f;
>>> - *(u32 *)loc |= 0x01a0f000;
>>> - break;
>>> + write_instr32((read_instr32(loc) & 0xf000000f) |
>>> + 0x01a0f000, loc);
>>> + break;
>>>
>>
>> Indentation error.
>>
>>
> Actually, The indentation of my code is right, and the original code is
> wrong.
Yes, you're right. Please precede your patch which a patch which _just_
corrects the formatting of the old code.
next prev parent reply other threads:[~2011-01-22 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 6:44 [PATCH V2 0/3] Support BE8 kernel modules relocation Stanley.Miao
2011-01-19 6:44 ` [PATCH 1/3] Support BE8 mode " Stanley.Miao
2011-01-21 9:40 ` Stanley.Miao
2011-01-21 9:44 ` Russell King - ARM Linux
2011-01-21 10:11 ` stanley.miao
2011-01-22 17:00 ` Russell King - ARM Linux [this message]
2011-01-19 6:44 ` [PATCH 2/3] support ARM BE8 mode on a little endian machine Stanley.Miao
2011-01-21 9:46 ` Russell King - ARM Linux
2011-01-21 10:51 ` Stanley.Miao
2011-01-19 6:44 ` [PATCH 3/3] Add ARM kernel debug macros for locating the boot problems quickly Stanley.Miao
-- strict thread matches above, loose matches on Subject: below --
2011-01-17 8:42 [PATCH 0/3] Support BE8 kernel modules relocation Stanley.Miao
2011-01-17 8:42 ` [PATCH 1/3] Support BE8 mode " Stanley.Miao
2011-01-17 8:52 ` Russell King - ARM Linux
2011-01-17 9:56 ` Catalin Marinas
2011-01-18 1:22 ` Stanley.Miao
2011-01-18 15:23 ` Catalin Marinas
2011-01-19 6:21 ` Stanley.Miao
2011-01-19 17:32 ` Catalin Marinas
2011-01-21 9:39 ` stanley.miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110122170044.GA12982@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).