From mboxrd@z Thu Jan  1 00:00:00 1970
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
Date: Sat, 22 Jan 2011 17:00:44 +0000
Subject: [PATCH 1/3] Support BE8 mode kernel modules relocation
In-Reply-To: <4D395BE1.2050806@windriver.com>
References: <1295419487-31185-1-git-send-email-stanley.miao@windriver.com>
	<1295419487-31185-2-git-send-email-stanley.miao@windriver.com>
	<20110121094446.GF13235@n2100.arm.linux.org.uk>
	<4D395BE1.2050806@windriver.com>
Message-ID: <20110122170044.GA12982@n2100.arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Jan 21, 2011 at 06:11:45PM +0800, stanley.miao wrote:
> Russell King - ARM Linux wrote:
>> On Wed, Jan 19, 2011 at 02:44:45PM +0800, Stanley.Miao wrote:
>>   
>>> @@ -174,9 +186,9 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
>>>  			* other bits to re-code instruction as
>>>  			* MOV PC,Rm.
>>>  			*/
>>> -		       *(u32 *)loc &= 0xf000000f;
>>> -		       *(u32 *)loc |= 0x01a0f000;
>>> -		       break;
>>> +			write_instr32((read_instr32(loc) & 0xf000000f) |
>>> +							0x01a0f000, loc);
>>> +			break;
>>>     
>>
>> Indentation error.
>>
>>   
> Actually, The indentation of my code is right, and the original code is  
> wrong.

Yes, you're right.  Please precede your patch which a patch which _just_
corrects the formatting of the old code.