From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Nexus One Support
Date: Sat, 22 Jan 2011 15:41:29 -0500 [thread overview]
Message-ID: <20110122204129.GA8666@infradead.org> (raw)
In-Reply-To: <20110122122018.GC5194@n2100.arm.linux.org.uk>
On Sat, Jan 22, 2011 at 12:20:18PM +0000, Russell King - ARM Linux wrote:
> I've asked Daniel in private whether he'd mind posting the original
> set of patches which he based his work on to this thread.
>
> I suspect that the situation is that there's many patches which he's
> taken from the repository and consolidated them down into a nice set
> of easy to review patches.
>
> One of the problems of preserving the micro-detail of history right
> from the early inception of support for a platform is that quite often
> the early support is buggy or broken - it might not even compile. There
> may be 20 or so patches on top of that which eventually get it to a
> usable state.
>
> Do we really want to put off people from reviewing patches because of
> the size of micro-development that happened prior to getting to a point
> where the result of that development is usable?
No, not at all. And I'm really annoyed at all the pointless flaming
here as people obviously never had to massage a completely messy
repository into something submittable. That usually doesn't just
include making useful commits, but also updates to current APIs, bug
fixing, removing crap that should never make it's way upstream (and
Android had quite a lot of the latter last time I looked).
The only think that Daniel did wrong was to not attribute the original
authors in the commit message, and not explaining his own contribution.
next prev parent reply other threads:[~2011-01-22 20:41 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:32 [PATCH 0/7] Nexus One Support Daniel Walker
2011-01-20 20:32 ` [PATCH 1/7] msm: qsd8x50: add uart platform data Daniel Walker
2011-01-20 20:32 ` [PATCH 2/7] [ARM] msm: qsd8k memory base is at 0x20000000 Daniel Walker
2011-01-20 20:32 ` [PATCH 3/7] msm: qsd8x50: add acpuclock code Daniel Walker
2011-01-20 20:32 ` [PATCH 4/7] msm: mahimahi: add mahimahi board file Daniel Walker
2011-01-20 20:32 ` [PATCH 5/7] msm: mahimahi: add in mmc support code Daniel Walker
2011-01-20 20:32 ` [PATCH 6/7] msm: mahimahi: add gpio pin muxing code Daniel Walker
2011-01-20 20:32 ` [PATCH 7/7] msm: mahimahi: initialize mmc at start up Daniel Walker
2011-01-21 0:42 ` [PATCH 0/7] Nexus One Support Dima Zavin
2011-01-21 0:55 ` Daniel Walker
2011-01-21 1:41 ` Joe Perches
2011-01-21 1:58 ` Daniel Walker
2011-01-21 2:13 ` Dima Zavin
2011-01-21 15:47 ` Daniel Walker
2011-01-21 2:25 ` Joe Perches
2011-01-21 3:41 ` Theodore Tso
2011-01-21 15:46 ` Daniel Walker
2011-01-21 17:48 ` Jesse Barnes
2011-01-21 17:56 ` Daniel Walker
2011-01-21 17:59 ` Christoph Hellwig
2011-01-21 17:56 ` Jesse Barnes
2011-01-21 18:00 ` Daniel Walker
2011-01-21 18:04 ` Jesse Barnes
2011-01-21 18:18 ` Daniel Walker
2011-01-21 18:27 ` Jesse Barnes
2011-01-21 18:35 ` Daniel Walker
2011-01-21 20:44 ` Dima Zavin
2011-01-21 20:49 ` Daniel Walker
2011-01-21 21:01 ` Jesse Barnes
2011-01-21 21:26 ` Daniel Walker
2011-01-21 21:42 ` Dima Zavin
2011-01-22 13:58 ` David Woodhouse
2011-01-21 21:02 ` Joe Perches
2011-01-21 21:24 ` Daniel Walker
2011-01-22 11:18 ` Pekka Enberg
2011-01-22 12:20 ` Russell King - ARM Linux
2011-01-22 18:06 ` Dima Zavin
2011-01-22 18:49 ` Russell King - ARM Linux
2011-01-22 20:50 ` Christoph Hellwig
2011-01-22 19:22 ` Brian Swetland
2011-01-22 19:49 ` Nicolas Pitre
2011-01-22 19:59 ` Brian Swetland
2011-01-22 20:53 ` Christoph Hellwig
2011-01-22 21:04 ` Russell King - ARM Linux
2011-01-22 21:57 ` Alan Cox
2011-01-23 2:38 ` David Woodhouse
2011-01-22 20:41 ` Christoph Hellwig [this message]
2011-01-21 21:05 ` Pekka Enberg
2011-01-21 21:17 ` Joe Perches
2011-01-21 23:49 ` Ted Ts'o
2011-01-22 0:03 ` Daniel Walker
2011-01-22 1:58 ` Steven Rostedt
2011-01-22 2:13 ` Daniel Walker
2011-01-22 2:32 ` Steven Rostedt
2011-01-22 2:31 ` Ted Ts'o
2011-01-22 8:19 ` Pekka Enberg
2011-01-22 10:35 ` Dima Zavin
2011-01-22 10:45 ` Anca Emanuel
2011-01-22 11:03 ` Pekka Enberg
2011-01-22 11:15 ` Pekka Enberg
2011-01-22 17:28 ` Thomas Gleixner
2011-01-22 18:07 ` Denis 'GNUtoo' Carikli
2011-01-22 18:15 ` Dima Zavin
2011-01-22 20:55 ` Christoph Hellwig
2011-01-22 21:56 ` Pekka Enberg
2011-01-22 21:58 ` Christoph Hellwig
2011-01-22 22:13 ` Pekka Enberg
2011-02-04 13:36 ` Pavel Machek
2011-02-07 17:36 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110122204129.GA8666@infradead.org \
--to=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).