From mboxrd@z Thu Jan 1 00:00:00 1970 From: segooon@gmail.com (Vasiliy Kulikov) Date: Mon, 24 Jan 2011 23:14:48 +0300 Subject: [PATCH 2/4] arch/arm/mach-at91/clock.c: Add missing IS_ERR test In-Reply-To: References: <1295898922-18822-1-git-send-email-julia@diku.dk> <1295898922-18822-3-git-send-email-julia@diku.dk> <4D3DD964.9020107@bluewatersys.com> <20110124200515.GA30963@albatros> Message-ID: <20110124201447.GA31162@albatros> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 24, 2011 at 21:09 +0100, Julia Lawall wrote: > On Mon, 24 Jan 2011, Vasiliy Kulikov wrote: > > clk_get() is defined per-architecture, sometimes it is NULL only. > > In this case there is a definition in the same file, so it doesn't seem > necessary to worry about possible other ones. Unless there is some goal > in the future to remove the local one? My oppinion is that even such architecture dependent code written in architecure indepenent way is highly desirable. Besides more clean code it is probably review by smaller group of people, so it is potentially more buggy. Thanks, -- Vasiliy