From: manjugk@ti.com (G, Manjunath Kondaiah)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode
Date: Wed, 26 Jan 2011 06:11:28 +0530 [thread overview]
Message-ID: <20110126004128.GA8524@manju-desktop> (raw)
In-Reply-To: <20110124093349.GC16582@m-desktop>
On Mon, Jan 24, 2011 at 03:03:49PM +0530, G, Manjunath Kondaiah wrote:
> Paul/Benoit,
>
> On Tue, Dec 14, 2010 at 07:18:22AM +0530, G, Manjunath Kondaiah wrote:
> > Paul/Benoit,
> >
> > On Fri, Dec 03, 2010 at 01:19:06PM +0100, Cousson, Benoit wrote:
> > > On 12/3/2010 10:47 AM, G, Manjunath Kondaiah wrote:
> > > >* Cousson, Benoit<b-cousson@ti.com> [2010-12-03 09:38:35 +0100]:
> > >
> > > [...]
> > >
> > > >>>v7: replaced mutex lock with spin lock. Added use count for controlling
> > > >>>access to sysconfig registers in case if overlapping request/release API's
> > > >>>are used.
> > > >>
> > > >>I'm not sure it should be done here. I'd rather keep that code in
> > > >>the DMA, since this is the only user of that feature.
> > > >
> > > >Are you referring to spin lock or usage count?
> > >
> > > The spinlock is needed, I was referring to the usage count.
> > >
> > > That being said, the API proposed by Paul (request/release
> > > ) sound like a get/put, so maybe he had that kind of usage in mind.
> > >
> > > I'm still not convince it should be done at hwmod API level.
> > >
> > >
> > > Paul,
> > > Any thoughts on that?
> >
> > How do we proceed further?
> Gentle reminder!
>
> Can we please align on this so that DMA sysconfig patches can be
> upstreamed?
>
> Discussion on this topic can be accessed at:
> https://patchwork.kernel.org/patch/372231/
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg39728.html
As there is no response from paul on this topic, I will go ahead with usage
count logic proposed by Adrian Hunter <adrian.hunter@nokia.com> at:
https://patchwork.kernel.org/patch/366831/
Above logic has got:
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
-Manjunath
next prev parent reply other threads:[~2011-01-26 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291298392-28729-1-git-send-email-manjugk@ti.com>
2010-12-02 14:23 ` [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode G, Manjunath Kondaiah
2010-12-03 8:38 ` Cousson, Benoit
2010-12-03 9:47 ` G, Manjunath Kondaiah
2010-12-03 12:19 ` Cousson, Benoit
2010-12-14 1:48 ` G, Manjunath Kondaiah
2011-01-24 9:33 ` G, Manjunath Kondaiah
2011-01-26 0:41 ` G, Manjunath Kondaiah [this message]
2011-01-26 19:05 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126004128.GA8524@manju-desktop \
--to=manjugk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).