From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mxs: fix clock base address missing
Date: Wed, 26 Jan 2011 16:58:58 +0100 [thread overview]
Message-ID: <20110126155858.GP9041@pengutronix.de> (raw)
In-Reply-To: <1296080796-10896-1-git-send-email-shawn.guo@freescale.com>
On Thu, Jan 27, 2011 at 06:26:36AM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> arch/arm/mach-mxs/clock-mx23.c | 2 +-
> arch/arm/mach-mxs/clock-mx28.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c
> index b1a362e..a0296a4 100644
> --- a/arch/arm/mach-mxs/clock-mx23.c
> +++ b/arch/arm/mach-mxs/clock-mx23.c
> @@ -347,7 +347,7 @@ static int name##_set_parent(struct clk *clk, struct clk *parent) \
> { \
> if (parent != clk->parent) { \
> __raw_writel(BM_CLKCTRL_CLKSEQ_BYPASS_##bit, \
> - HW_CLKCTRL_CLKSEQ_TOG); \
> + CLKCTRL_BASE_ADDR + HW_CLKCTRL_CLKSEQ_TOG); \
> clk->parent = parent; \
> } \
> \
While at it you could also add some parameter checking to this function.
Implemented like this it behaves rather randomly.
Sascha
> diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
> index 56312c0..44c1754 100644
> --- a/arch/arm/mach-mxs/clock-mx28.c
> +++ b/arch/arm/mach-mxs/clock-mx28.c
> @@ -483,7 +483,7 @@ static int name##_set_parent(struct clk *clk, struct clk *parent) \
> { \
> if (parent != clk->parent) { \
> __raw_writel(BM_CLKCTRL_CLKSEQ_BYPASS_##bit, \
> - HW_CLKCTRL_CLKSEQ_TOG); \
> + CLKCTRL_BASE_ADDR + HW_CLKCTRL_CLKSEQ_TOG); \
> clk->parent = parent; \
> } \
> \
> --
> 1.7.1
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-01-26 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 22:26 [PATCH] ARM: mxs: fix clock base address missing Shawn Guo
2011-01-26 15:58 ` Sascha Hauer [this message]
2011-01-27 23:19 ` Shawn Guo
2011-01-27 15:31 ` Sascha Hauer
2011-01-28 21:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126155858.GP9041@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).