From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc
Date: Fri, 28 Jan 2011 08:51:58 -0800 [thread overview]
Message-ID: <20110128165158.GU23412@atomide.com> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B036AA2EC2E@dbde02.ent.ti.com>
* Ghorai, Sukumar <s-ghorai@ti.com> [110128 00:14]:
>
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony at atomide.com]
> > Sent: Tuesday, January 25, 2011 10:28 PM
> > To: Ghorai, Sukumar
> > Cc: linux-omap at vger.kernel.org; linux-mtd at lists.infradead.org; linux-arm-
> > kernel at lists.infradead.org
> > Subject: Re: [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc
> >
> > * Ghorai, Sukumar <s-ghorai@ti.com> [110122 09:53]:
> > > >
> > > > I think I've commented on this before, but why don't you make
> > gpmc_init
> > > > a subsys_initcall? There should be no reason to call this earlier.
> > > > If something does not work because of that, then that issue must be
> > > > fixed.
> > >
> > > [Ghorai] You suggested the same in previous v5 and v6; and I mentioned
> > > the issues [1] that - nand_init()called before
> > subsys_initcall(gpmc_init);
> > > Let me know if I am missing anything again.
> >
> > There should not be any need to call nand_init early either. We want
> > to initialize as much as possible late so we have proper console
> > error messages.
>
> [Ghorai] thanks...
> changed to postcore_initcall() and it solved the problem I mentioned earlier. And it simplifies the overall modification in different board files.
> postcore_initcall(gpmc_init);
OK great. I will check the order of initcalls anyways over next few
weeks, so whatever works for the initcall is fine for now.
Regards,
Tony
next prev parent reply other threads:[~2011-01-28 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 13:24 [PATCH RESEND v8 0/7] nand prefetch-irq support and ecc layout chanage Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 1/7] omap3630: nand: fix device size to work in polled mode Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 2/7] omap3: nand: configurable transfer type per board Sukumar Ghorai
2011-01-19 13:24 ` [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc Sukumar Ghorai
2011-01-21 18:40 ` Tony Lindgren
2011-01-22 17:54 ` Ghorai, Sukumar
2011-01-25 16:57 ` Tony Lindgren
2011-01-28 8:15 ` Ghorai, Sukumar
2011-01-28 16:51 ` Tony Lindgren [this message]
2011-01-19 13:25 ` [PATCH RESEND v8 5/7] omap3: nand: configurable fifo threshold to gain the throughput Sukumar Ghorai
2011-01-19 13:25 ` [PATCH RESEND v8 6/7] omap3: nand: ecc layout select from board file Sukumar Ghorai
2011-01-19 13:25 ` [PATCH RESEND v8 7/7] omap3: nand: making ecc layout as compatible with romcode ecc Sukumar Ghorai
2011-07-08 17:38 ` [PATCH RESEND v8 4/7] omap3: nand: prefetch in irq mode support Sukumar Ghorai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128165158.GU23412@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).