From: richard.zhao@freescale.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: imx53_loco: add all pad configure.
Date: Sun, 30 Jan 2011 10:09:40 +0800 [thread overview]
Message-ID: <20110130020939.GA16528@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <AANLkTiktMZ6K1Vx1JFFyJOr6FmnEwaV8DPkAnHT=XMho@mail.gmail.com>
On Sat, Jan 29, 2011 at 03:05:50PM -0200, Fabio Estevam wrote:
> On Sat, Jan 29, 2011 at 12:11 PM, Richard Zhao <linuxzsc@gmail.com> wrote:
> > On Sat, Jan 29, 2011 at 11:31:38AM -0200, Fabio Estevam wrote:
> >> Hi Richard,
> >>
> >> On Sat, Jan 29, 2011 at 8:48 AM, Richard Zhao <linuxzsc@gmail.com> wrote:
> >> > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
> >> >
> >> > diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> >> > index 3aefd6d..d724ac8 100644
> >> > --- a/arch/arm/mach-mx5/board-mx53_loco.c
> >> > +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> >> > @@ -39,8 +39,145 @@
> >> > ?#define LOCO_FEC_PHY_RST ? ? ? ? ? ? ? IMX_GPIO_NR(7, 6)
> >>
> >> Don?t you also need to define the PAD_CTRL settings for the different
> >> peripherals in iomux-53.h?
> > Dinh is doing the SoC level work. I don't think I need to repeat the effort.
>
> Then don?t you think it is better to add the board level IOMUX after
> Dinh?s work?
I don't think so. We already have Dinh's initial version of iomux-mx53.h. It can
pass build and work for current device added.
At least we have correct mux set, we can test on that. When we summit new device
drivers, we can check the pad settings and fix it in case we don't have correct
one yet.
It's also the way we can upstream as fast as possible.
Thanks
Richard
>
> Regards,
>
> Fabio Estevam
>
prev parent reply other threads:[~2011-01-30 2:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-29 10:48 [PATCH 1/1] ARM: imx53_loco: add all pad configure Richard Zhao
2011-01-29 13:31 ` Fabio Estevam
2011-01-29 14:11 ` Richard Zhao
2011-01-29 17:05 ` Fabio Estevam
2011-01-30 2:09 ` Richard Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110130020939.GA16528@shlinux1.ap.freescale.net \
--to=richard.zhao@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).