From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard.zhao@freescale.com (Richard Zhao) Date: Sun, 30 Jan 2011 10:09:40 +0800 Subject: [PATCH 1/1] ARM: imx53_loco: add all pad configure. In-Reply-To: References: <1296298099-16611-1-git-send-email-richard.zhao@freescale.com> <20110129141112.GA3483@richard-laptop> Message-ID: <20110130020939.GA16528@shlinux1.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jan 29, 2011 at 03:05:50PM -0200, Fabio Estevam wrote: > On Sat, Jan 29, 2011 at 12:11 PM, Richard Zhao wrote: > > On Sat, Jan 29, 2011 at 11:31:38AM -0200, Fabio Estevam wrote: > >> Hi Richard, > >> > >> On Sat, Jan 29, 2011 at 8:48 AM, Richard Zhao wrote: > >> > Signed-off-by: Richard Zhao > >> > > >> > diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c > >> > index 3aefd6d..d724ac8 100644 > >> > --- a/arch/arm/mach-mx5/board-mx53_loco.c > >> > +++ b/arch/arm/mach-mx5/board-mx53_loco.c > >> > @@ -39,8 +39,145 @@ > >> > ?#define LOCO_FEC_PHY_RST ? ? ? ? ? ? ? IMX_GPIO_NR(7, 6) > >> > >> Don?t you also need to define the PAD_CTRL settings for the different > >> peripherals in iomux-53.h? > > Dinh is doing the SoC level work. I don't think I need to repeat the effort. > > Then don?t you think it is better to add the board level IOMUX after > Dinh?s work? I don't think so. We already have Dinh's initial version of iomux-mx53.h. It can pass build and work for current device added. At least we have correct mux set, we can test on that. When we summit new device drivers, we can check the pad settings and fix it in case we don't have correct one yet. It's also the way we can upstream as fast as possible. Thanks Richard > > Regards, > > Fabio Estevam >