From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: make sure DMA transfers wait for FIFO drain
Date: Tue, 1 Feb 2011 11:03:48 +0000 [thread overview]
Message-ID: <20110201110348.GB31216@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1296509980-29987-1-git-send-email-linus.walleij@linaro.org>
On Mon, Jan 31, 2011 at 10:39:40PM +0100, Linus Walleij wrote:
> The DMA mode also needs to wait until the FIFO is drained before
> enabling the MCI_DATAEND IRQ.
Hmm. This will cause attempted DMA usage on ARM MMCI primecells to get
stuck as we'll wait for the never-delivered callback.
With the code I have in place, you'll notice I have:
/* Wait up to 1ms for the DMA to complete */
for (i = 0; ; i++) {
status = readl(host->base + MMCISTATUS);
if (!(status & MCI_RXDATAAVLBLMASK) || i >= 100)
break;
udelay(10);
}
This waits for the DMA controller to read the last data out of the FIFO
before allowing the request to complete. As it has a timeout, it is
able to detect ARMs broken DMA setup on their MMCI/DMAC, and disable DMA
support for this primecell rather than getting stuck.
This may be sufficient without using the DMA callbacks.
next prev parent reply other threads:[~2011-02-01 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 21:39 [PATCH] mmci: make sure DMA transfers wait for FIFO drain Linus Walleij
2011-02-01 11:03 ` Russell King - ARM Linux [this message]
2011-02-01 14:11 ` Linus Walleij
2011-02-11 9:46 ` Linus Walleij
2011-02-11 10:10 ` Russell King - ARM Linux
2011-02-11 10:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201110348.GB31216@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).