linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: restrict DMA usage to large, even multiblock transfers
Date: Tue, 1 Feb 2011 11:45:22 +0000	[thread overview]
Message-ID: <20110201114522.GD31216@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D47EFB6.5090509@stericsson.com>

On Tue, Feb 01, 2011 at 12:34:14PM +0100, Ulf Hansson wrote:
> Getting FIFO overrun/underruns is then as of today already the case when  
> running PIO for ARM primecell. To prevent this; you probably now that  
> already, hardware flow control is implemented in ST version of the ARM  
> primecell.

That really doesn't matter.  This driver is not specific to the ST
version.  It has to work on other versions as well.

I would like to see some further discussion on the unresolved issue of
the burst size setting - the discussion between myself and Linus died
without any apparant conclusion.  Linus tried to get some knowledgable
people from ST involved but no one ever followed up.

What I gathered from the discussion was that the additional DMA enable
bit found in ST variants should not be set as this changes the behaviour
of the DMA requests to be incompatible with the DMA controller
requirements.  With that bit clear, I see no problem with leaving the
burst threshold set at the half FIFO size.

That then makes avoiding DMA for requests below a specific size an
optimization issue and nothing more.

  reply	other threads:[~2011-02-01 11:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 10:41 [PATCH] mmci: restrict DMA usage to large, even multiblock transfers Linus Walleij
2011-02-01 10:54 ` Russell King - ARM Linux
2011-02-01 11:34   ` Ulf Hansson
2011-02-01 11:45     ` Russell King - ARM Linux [this message]
2011-02-01 11:56       ` Ulf Hansson
2011-02-01 11:58       ` Russell King - ARM Linux
2011-02-01 14:07         ` Linus Walleij
2011-02-01 14:44           ` Russell King - ARM Linux
2011-02-02  9:39             ` Linus Walleij
2011-02-01 15:05           ` Russell King - ARM Linux
2011-02-02  9:34             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201114522.GD31216@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).