linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints
Date: Tue, 1 Feb 2011 20:27:25 +0200	[thread overview]
Message-ID: <20110201202725.804aa011.jhnikula@gmail.com> (raw)
In-Reply-To: <1296574588-23588-1-git-send-email-aaro.koskinen@nokia.com>

On Tue,  1 Feb 2011 17:36:28 +0200
Aaro Koskinen <aaro.koskinen@nokia.com> wrote:

> With the commit 757902513019e6ee469791ff76f954b19ca8d036 fixed voltage
> regulator setup will fail if there are voltage constraints defined. This
> made MMC unusable on this board. Fix by just deleting those redundant
> constraints.
> 
True. Before there were a test min_uV == max_uV && ops->set_voltage and
now min_uV == max_uV followed by test for ops->set_voltage that returns
EINVAL if not set (NULL for fixed voltage regulator obviously).

Reviewed-by: Jarkko Nikula <jhnikula@gmail.com>

  reply	other threads:[~2011-02-01 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 15:36 [PATCH] arm: mach-omap2: board-rm680: fix rm680_vemmc regulator constraints Aaro Koskinen
2011-02-01 18:27 ` Jarkko Nikula [this message]
2011-02-01 23:52   ` Tony Lindgren
2011-02-04 13:31 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201202725.804aa011.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).