linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM unaligned MMIO access with attribute((packed))
Date: Wed, 02 Feb 2011 15:23:50 -0800 (PST)	[thread overview]
Message-ID: <20110202.152350.28800670.davem@davemloft.net> (raw)
In-Reply-To: <yw1xei7qm3vy.fsf@unicorn.mansr.com>

From: M?ns Rullg?rd <mans@mansr.com>
Date: Wed, 02 Feb 2011 23:08:01 +0000

> David Miller <davem@davemloft.net> writes:
> 
>> From: Russell King - ARM Linux <linux@arm.linux.org.uk>
>> Date: Wed, 2 Feb 2011 16:37:02 +0000
>>
>>> 1. there's no way to tell GCC that the inline assembly is a load
>>>    instruction and therefore it needs to schedule the following
>>>    instructions appropriately.
>>
>> Just add a dummy '"m" (pointer)' asm input argument to the inline asm
>> statement.  Just make sure "typeof(pointer)" has a size matching the
>> size of the load your are performing.
> 
> That should be "m"(*pointer).

Right, thanks for the correction.

>> But you really need that memory clobber there whether you like it or
>> not, see above.
> 
> I don't know of any device where the side-effects are not explicitly
> indicated by other means in the code triggering them, so it probably
> is safe without the clobber as Russel says.

You're probably right.

  parent reply	other threads:[~2011-02-02 23:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 16:00 ARM unaligned MMIO access with attribute((packed)) Arnd Bergmann
2011-02-02 16:37 ` Russell King - ARM Linux
2011-02-02 17:39   ` Arnd Bergmann
2011-02-02 19:14     ` Ian Lance Taylor
2011-02-02 21:38   ` David Miller
2011-02-02 21:45     ` Russell King - ARM Linux
2011-02-02 21:59       ` David Miller
     [not found]     ` <yw1xei7qm3vy.fsf@unicorn.mansr.com>
2011-02-02 23:23       ` David Miller [this message]
2011-02-03  9:26       ` Arnd Bergmann
2011-02-03 15:03   ` Arnd Bergmann
2011-02-02 16:51 ` Richard Guenther
2011-02-02 17:09   ` Russell King - ARM Linux
2011-02-02 17:39   ` Joseph S. Myers
2011-04-26 15:00 ` Rabin Vincent
2011-04-26 18:51   ` Alan Stern
2011-04-27 14:06     ` Rabin Vincent
2011-04-27 16:25       ` Alan Stern
2011-04-27 16:37         ` Arnd Bergmann
2011-04-28 13:35           ` Alan Stern
2011-04-28 14:16             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202.152350.28800670.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).