linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure)
Date: Tue, 1 Feb 2011 17:10:07 -0800	[thread overview]
Message-ID: <20110202011006.GP3358@atomide.com> (raw)
In-Reply-To: <3c13ae6d9e13b94548bfcaaced7681e8@mail.gmail.com>

* Anand Gadiyar <gadiyar@ti.com> [110201 04:54]:
> 
> I believe this fix is fixing your reboot issue, but it's breaking
> EHCI support on the SDP.
> 
> The MODE4 above should really be MODE3 - all GPIOs are on MODE3.
> By changing
> 
> The patch snippet below fixes EHCI on the SDP, but I believe that
> making this change will reintroduce the "board reboots" issue
> you originally reported. Could you check and tell me if this
> is the case?

Hmm sorry looks like I made a typo there. That should be fixed.
 
> Just curious - is your board a Blaze, or an SDP?

It's a ES1.0 blaze, with the patch below it reboots early
during the boot. I also have to disable omap_l2_cache_init
on this board to get it to boot.
 
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c
> b/arch/arm/mach-omap2/board-4430sdp.c
> index 07d1b20..ab9fb4d 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -554,7 +554,7 @@ static void __init omap_sfh7741prox_init(void)
> 
>  #ifdef CONFIG_OMAP_MUX
>  static struct omap_board_mux board_mux[] __initdata = {
> -	OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
> +	OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT),
>  	{ .reg_offset = OMAP_MUX_TERMINATOR },
>  };
>  #else

Maybe there should be a check for ES1.0 for the USB also?

Tony

  reply	other threads:[~2011-02-02  1:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110106170805.GE1198@n2100.arm.linux.org.uk>
     [not found] ` <20110106180030.GA8249@n2100.arm.linux.org.uk>
     [not found]   ` <20110106182023.GV7771@atomide.com>
     [not found]     ` <20110106203238.GH1198@n2100.arm.linux.org.uk>
     [not found]       ` <20110106204053.GA7771@atomide.com>
     [not found]         ` <20110107161230.GR1198@n2100.arm.linux.org.uk>
     [not found]           ` <20110110185209.GC4957@atomide.com>
2011-01-11 23:16             ` [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure) Tony Lindgren
2011-01-13  8:52               ` Anand Gadiyar
2011-01-13  9:15                 ` Russell King - ARM Linux
2011-01-13 15:51                   ` Tony Lindgren
2011-01-13 16:49                     ` Russell King - ARM Linux
2011-01-14 17:29                       ` Tony Lindgren
2011-01-14 19:18                       ` Paul Walmsley
2011-01-14 21:20                         ` Russell King - ARM Linux
2011-01-14 22:07                           ` Paul Walmsley
2011-01-14 23:10                           ` Paul Walmsley
2011-01-14 23:58                             ` Russell King - ARM Linux
2011-01-15  0:12                               ` Tony Lindgren
2011-01-15  0:25                                 ` Russell King - ARM Linux
2011-01-15  0:37                                   ` Tony Lindgren
2011-01-15 17:04                                     ` Russell King - ARM Linux
2011-01-17  8:35                                       ` Sascha Hauer
2011-02-01 12:55               ` Anand Gadiyar
2011-02-02  1:10                 ` Tony Lindgren [this message]
2011-02-02  6:05                   ` Santosh Shilimkar
2011-02-02 19:48                     ` Tony Lindgren
2011-02-03  8:43                       ` Santosh Shilimkar
2011-02-12  8:46                         ` Santosh Shilimkar
2011-02-24 17:38                           ` Tony Lindgren
2011-02-25  5:33                             ` Santosh Shilimkar
2011-02-25 17:49                               ` Tony Lindgren
2011-02-02 18:43                   ` Anand Gadiyar
2011-02-02 19:50                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202011006.GP3358@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).