public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards
Date: Wed, 2 Feb 2011 10:51:47 +0000	[thread overview]
Message-ID: <20110202105146.GA9810@sirena.org.uk> (raw)
In-Reply-To: <1296603653.1504.9.camel@r60e>

On Wed, Feb 02, 2011 at 02:40:53AM +0300, Alexander Sverdlin wrote:

> +	err = gpio_request(gpio_nreset, spi->modalias);
> +	if (err)
> +		return err;
> +	err = gpio_request(EP93XX_GPIO_LINE_EGPIO6, spi->modalias);
> +	if (err)
> +		return err;
> +
> +	gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 1);

Why is this stuff in the arch/arm code?  I'd expect driver to deal with
all this sequencing.

      parent reply	other threads:[~2011-02-02 10:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 23:40 [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Alexander Sverdlin
2011-02-02  0:02 ` H Hartley Sweeten
2011-02-02 10:48   ` Alexander Sverdlin
2011-02-02 10:49     ` Mark Brown
2011-02-02 11:12       ` Alexander Sverdlin
2011-02-02 12:53         ` Mark Brown
2011-02-02 13:26           ` Alexander Sverdlin
2011-02-02 16:53             ` H Hartley Sweeten
2011-02-02 17:00               ` Mark Brown
2011-02-02 17:21                 ` H Hartley Sweeten
2011-02-02 17:33                 ` Alexander Sverdlin
2011-02-02 17:48                   ` H Hartley Sweeten
2011-02-02 18:31                   ` Mark Brown
2011-02-02 18:18             ` H Hartley Sweeten
2011-02-02 16:45     ` H Hartley Sweeten
2011-02-02  7:54 ` [alsa-devel] " Mika Westerberg
2011-02-02 16:27   ` H Hartley Sweeten
2011-02-02 10:51 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202105146.GA9810@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox