From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL
Date: Thu, 3 Feb 2011 19:07:58 +0000 [thread overview]
Message-ID: <20110203190758.GA15004@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <b0242fa556f17e47222fa7f30a36d75b@mail.gmail.com>
On Fri, Feb 04, 2011 at 12:09:34AM +0530, Santosh Shilimkar wrote:
> > -----Original Message-----
> > From: Dave Martin [mailto:dave.martin at linaro.org]
> > Sent: Thursday, February 03, 2011 11:33 PM
> > To: linux-arm-kernel at lists.infradead.org
> > Cc: Dave Martin; Tony Lindgren; Santosh Shilimkar; Jean Pihet;
> > linux-omap at vger.kernel.org; Nicolas Pitre
> > Subject: [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi()
> > for CONFIG_THUMB2_KERNEL
> >
> > For the Thumb-2 case, the "wfi" mnemonic is used, since in this
> > case the tools will necessarily be new enough to support it.
> >
> > Signed-off-by: Dave Martin <dave.martin@linaro.org>
>
> I guess, we discussed this patch in your previous post.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> > ---
> > arch/arm/mach-omap2/include/mach/omap4-common.h | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/include/mach/omap4-common.h
> > b/arch/arm/mach-omap2/include/mach/omap4-common.h
> > index 5b0270b..68ce058 100644
> > --- a/arch/arm/mach-omap2/include/mach/omap4-common.h
> > +++ b/arch/arm/mach-omap2/include/mach/omap4-common.h
> > @@ -17,8 +17,13 @@
> > * wfi used in low power code. Directly opcode is used instead
> > * of instruction to avoid mulit-omap build break
> > */
> > +#ifdef CONFIG_THUMB2_KERNEL
> > +#define do_wfi() \
> > + __asm__ __volatile__ ("wfi" : : : "memory")
> > +#else
> > #define do_wfi() \
> > __asm__ __volatile__ (".word 0xe320f003" : : :
> > "memory")
> > +#endif
We actually have this:
#if __LINUX_ARM_ARCH__ >= 7 || \
(__LINUX_ARM_ARCH__ == 6 && defined(CONFIG_CPU_32v6K))
#define sev() __asm__ __volatile__ ("sev" : : : "memory")
#define wfe() __asm__ __volatile__ ("wfe" : : : "memory")
#define wfi() __asm__ __volatile__ ("wfi" : : : "memory")
#endif
in asm/system.h, so maybe it should be using wfe() from asm/system.h ?
next prev parent reply other threads:[~2011-02-03 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 18:02 [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes Dave Martin
2011-02-03 18:02 ` [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL Dave Martin
2011-02-03 18:39 ` Santosh Shilimkar
2011-02-03 19:07 ` Russell King - ARM Linux [this message]
2011-02-03 19:30 ` [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL Santosh Shilimkar
2011-02-04 10:58 ` Dave Martin
2011-02-04 11:18 ` Santosh Shilimkar
2011-02-03 18:02 ` [PATCH v2 2/5] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL Dave Martin
2011-02-03 18:02 ` [PATCH v2 3/5] ARM: omap3: Remove hand-encoded SMC instructions Dave Martin
2011-02-03 18:38 ` Santosh Shilimkar
2011-02-03 18:02 ` [PATCH v2 4/5] ARM: omap3: Thumb-2 compatibility for sram34xx.S Dave Martin
2011-02-03 18:42 ` Santosh Shilimkar
2011-02-03 18:02 ` [PATCH v2 5/5] ARM: omap3: Thumb-2 compatibility for sleep34xx.S Dave Martin
2011-02-03 18:47 ` Santosh Shilimkar
2011-02-10 22:17 ` Kevin Hilman
2011-02-11 0:07 ` Kevin Hilman
2011-02-11 13:49 ` Dave Martin
2011-02-11 9:43 ` Dave Martin
2011-02-04 10:45 ` [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes Santosh Shilimkar
2011-02-04 11:02 ` Dave Martin
2011-02-04 11:16 ` Santosh Shilimkar
2011-02-04 11:18 ` Dave Martin
2011-02-04 16:41 ` Dave Martin
2011-02-08 17:40 ` Dave Martin
2011-02-09 5:45 ` Santosh Shilimkar
2011-02-09 9:49 ` Dave Martin
2011-02-10 21:38 ` Kevin Hilman
2011-02-11 9:36 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203190758.GA15004@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).