From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] omap: Add support for CONFIG_AUTO_ZRELADDR for DEBUG_LL
Date: Fri, 4 Feb 2011 09:02:50 -0800 [thread overview]
Message-ID: <20110204170249.GV3322@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102032205140.12104@xanadu.home>
* Nicolas Pitre <nico@fluxnic.net> [110203 19:32]:
> On Thu, 3 Feb 2011, Tony Lindgren wrote:
>
> > This way we can have the debug-macro.S be common for omap1 and omap2+
> > and get sensible error messages booting the wrong zImage with
> > CONFIG_AUTO_ZRELADDR selected. Note that this does not seem to work
> > with u-boot and uImage.
...
> Gaaaaah! This is horrible.
-ENOREGISTERS :)
> OK, you do want to store data in memory, right? So the best way to
> always be position independent, even cross section, is to do the
> following (inspired by RMK's trick in the p2v series):
>
> .data
>
> foo: .word 0 @ value for sput
> .word 0 @ value for nik
>
> .text
>
> bar: .word .
> .word foo
>
> sputnik:
>
> adr r0, bar @ get relative address of bar
> ldr r1, [r0] @ get absolute address of bar
> sub r1, r1, r0 @ difference between abs and rel address
> ldr r0, [r0, #4] @ get absolute address of foo
> sub r0, r0, r1 @ turn that into a relative address
>
> ldmia r0, {r1, r2} @ retrieve sput and nik
> add r0, r1, r2
> mov pc, lr
>
> This code is totally position independent, so it works whether or not
> the MMU is active. Therefore a similar technique in your macro (you
> could even put it into a macro for it) would allow you to get rid of the
> mrc and test for MMU active, get rid of the #ifdef, and not be limited
> to a 128 MB mask, etc. And it is just one word longer than your
> shortest version i.e. 2 constants + 5 instructions vs 4 instructions + 2
> literal pool entries.
I think if we keep the address of the memory location in rx instead of
the port address value, then this could be done.
That would limit all the trickery to inituart only. Then addruart and
busyuart could just do ldr from the memory location to get the port
data without any trickery.
In that case the mapping of IO space for the serial port in head.S
would have to be changed as that relies on rx containing the port
IO address..
Regards,
Tony
next prev parent reply other threads:[~2011-02-04 17:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 1:26 [PATCH 0/5] Change omap DEBUG_LL code to use inituart for AUTO_ZRELADDR and ARM_PATCH_PHYS_VIRT Tony Lindgren
2011-02-04 1:27 ` [PATCH 1/5] omap: Remove code configuring the DEBUG_LL serial port using uncompress code Tony Lindgren
2011-02-04 1:27 ` [PATCH 2/5] omap: Use inituart to configure the debug serial port based on machine ID Tony Lindgren
2011-02-04 12:04 ` Grazvydas Ignotas
2011-02-04 16:49 ` Tony Lindgren
2011-02-04 1:27 ` [PATCH 3/5] omap: Add support for CONFIG_AUTO_ZRELADDR for DEBUG_LL Tony Lindgren
2011-02-04 3:33 ` Nicolas Pitre
2011-02-04 17:02 ` Tony Lindgren [this message]
2011-02-04 20:16 ` Nicolas Pitre
2011-02-04 20:24 ` Tony Lindgren
2011-02-04 20:33 ` Nicolas Pitre
2011-02-04 17:15 ` Russell King - ARM Linux
2011-02-04 18:36 ` Tony Lindgren
2011-02-04 1:27 ` [PATCH 4/5] omap: Combine debug-macro.S for omap1 and omap2+ Tony Lindgren
2011-02-04 1:27 ` [PATCH 5/5] omap: Add CONFIG_AUTO_ZRELADDR and CONFIG_ARM_PATCH_PHYS_VIRT to defconfigs Tony Lindgren
2011-02-09 6:08 ` [PATCH 0/5] Change omap DEBUG_LL code to use inituart for AUTO_ZRELADDR and ARM_PATCH_PHYS_VIRT Poddar, Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204170249.GV3322@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).