From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] dmaengine: mxs-dma: add dma support for i.MX23/28
Date: Sat, 5 Feb 2011 15:33:00 +0000 [thread overview]
Message-ID: <20110205153300.GA29411@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1296871696-21008-2-git-send-email-shawn.guo@freescale.com>
Shawn,
A couple more points below.
On Sat, Feb 05, 2011 at 10:08:12AM +0800, Shawn Guo wrote:
> + mxs_dma->dev = &pdev->dev;
...
> + mxs_dma->dma_device.dev = &pdev->dev;
Do you need mxs_dma->dev, or could you just use mxs_dma->dma_device.dev
throughout?
> +static int __exit mxs_dma_remove(struct platform_device *pdev)
> +{
> + return -EBUSY;
> +}
As the return code is ignored, it's probably better to omit the remove
function entirely.
next prev parent reply other threads:[~2011-02-05 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 2:08 Add dma support for i.MX23/28 Shawn Guo
2011-02-05 2:08 ` [PATCH 1/5] dmaengine: mxs-dma: add " Shawn Guo
2011-02-04 18:17 ` Russell King - ARM Linux
2011-02-08 22:56 ` Shawn Guo
2011-02-08 16:38 ` Russell King - ARM Linux
2011-02-05 15:33 ` Russell King - ARM Linux [this message]
2011-02-08 22:59 ` Shawn Guo
2011-02-07 7:37 ` Lothar Waßmann
2011-02-08 23:09 ` Shawn Guo
2011-02-07 8:25 ` Sascha Hauer
2011-02-07 9:09 ` Russell King - ARM Linux
2011-02-08 23:28 ` Shawn Guo
2011-02-09 8:34 ` Sascha Hauer
2011-02-09 21:42 ` Shawn Guo
2011-02-07 14:13 ` Lothar Waßmann
2011-02-08 23:30 ` Shawn Guo
2011-02-07 14:31 ` Lothar Waßmann
2011-02-08 23:38 ` Shawn Guo
2011-02-08 14:41 ` Lothar Waßmann
2011-02-09 0:17 ` Shawn Guo
2011-02-09 8:06 ` Lothar Waßmann
2011-02-09 20:42 ` Shawn Guo
2011-02-09 13:13 ` Lothar Waßmann
2011-02-14 0:16 ` Shawn Guo
2011-02-09 9:09 ` Sascha Hauer
2011-02-09 21:02 ` Shawn Guo
2011-02-05 2:08 ` [PATCH 2/5] ARM: mxs: add dma channel definitions Shawn Guo
2011-02-05 2:08 ` [PATCH 3/5] ARM: mxs: dynamically allocate dma device for mx23/28 Shawn Guo
2011-02-07 8:09 ` Sascha Hauer
2011-02-09 0:22 ` Shawn Guo
2011-02-05 2:08 ` [PATCH 4/5] ARM: mxs/mx23evk: add dma device Shawn Guo
2011-02-05 2:08 ` [PATCH 5/5] ARM: mxs/mx28evk: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110205153300.GA29411@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).