linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: mxs: dynamically allocate dma device for mx23/28
Date: Mon, 7 Feb 2011 09:09:45 +0100	[thread overview]
Message-ID: <20110207080945.GH9041@pengutronix.de> (raw)
In-Reply-To: <1296871696-21008-4-git-send-email-shawn.guo@freescale.com>

On Sat, Feb 05, 2011 at 10:08:14AM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
>  arch/arm/mach-mxs/clock-mx23.c                  |    3 +-
>  arch/arm/mach-mxs/clock-mx28.c                  |    4 +-
>  arch/arm/mach-mxs/devices-mx23.h                |    6 +++
>  arch/arm/mach-mxs/devices-mx28.h                |    6 +++
>  arch/arm/mach-mxs/devices/Kconfig               |    3 +
>  arch/arm/mach-mxs/devices/Makefile              |    1 +
>  arch/arm/mach-mxs/devices/platform-dma.c        |   50 +++++++++++++++++++++++
>  arch/arm/mach-mxs/include/mach/devices-common.h |    7 +++
>  8 files changed, 77 insertions(+), 3 deletions(-)
>  create mode 100644 arch/arm/mach-mxs/devices/platform-dma.c
> 
> diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h
> index 1256788..d5595ce 100644
> --- a/arch/arm/mach-mxs/devices-mx23.h
> +++ b/arch/arm/mach-mxs/devices-mx23.h
> @@ -14,3 +14,9 @@
>  extern const struct amba_device mx23_duart_device __initconst;
>  #define mx23_add_duart() \
>  	mxs_add_duart(&mx23_duart_device)
> +
> +extern const struct mxs_dma_data mx23_dma_data[] __initconst;
> +#define mx23_add_apbh_dma() \
> +	mxs_add_dma(&mx23_dma_data[0])
> +#define mx23_add_apbx_dma() \
> +	mxs_add_dma(&mx23_dma_data[1])
> diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h
> index 3b18304..e3a3bbc 100644
> --- a/arch/arm/mach-mxs/devices-mx28.h
> +++ b/arch/arm/mach-mxs/devices-mx28.h
> @@ -23,6 +23,12 @@ extern const struct mxs_auart_data mx28_auart_data[] __initconst;
>  #define mx28_add_auart3()		mx28_add_auart(3)
>  #define mx28_add_auart4()		mx28_add_auart(4)
>  
> +extern const struct mxs_dma_data mx28_dma_data[] __initconst;
> +#define mx28_add_apbh_dma() \
> +	mxs_add_dma(&mx28_dma_data[0])
> +#define mx28_add_apbx_dma() \
> +	mxs_add_dma(&mx28_dma_data[1])
> +

Given that the DMA device is fully internal to the SoC and always
present, does it make sense to add it dynamically and to leave
registration to the boards?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2011-02-07  8:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05  2:08 Add dma support for i.MX23/28 Shawn Guo
2011-02-05  2:08 ` [PATCH 1/5] dmaengine: mxs-dma: add " Shawn Guo
2011-02-04 18:17   ` Russell King - ARM Linux
2011-02-08 22:56     ` Shawn Guo
2011-02-08 16:38       ` Russell King - ARM Linux
2011-02-05 15:33   ` Russell King - ARM Linux
2011-02-08 22:59     ` Shawn Guo
2011-02-07  7:37   ` Lothar Waßmann
2011-02-08 23:09     ` Shawn Guo
2011-02-07  8:25   ` Sascha Hauer
2011-02-07  9:09     ` Russell King - ARM Linux
2011-02-08 23:28     ` Shawn Guo
2011-02-09  8:34       ` Sascha Hauer
2011-02-09 21:42         ` Shawn Guo
2011-02-07 14:13   ` Lothar Waßmann
2011-02-08 23:30     ` Shawn Guo
2011-02-07 14:31   ` Lothar Waßmann
2011-02-08 23:38     ` Shawn Guo
2011-02-08 14:41   ` Lothar Waßmann
2011-02-09  0:17     ` Shawn Guo
2011-02-09  8:06       ` Lothar Waßmann
2011-02-09 20:42         ` Shawn Guo
2011-02-09 13:13           ` Lothar Waßmann
2011-02-14  0:16         ` Shawn Guo
2011-02-09  9:09     ` Sascha Hauer
2011-02-09 21:02       ` Shawn Guo
2011-02-05  2:08 ` [PATCH 2/5] ARM: mxs: add dma channel definitions Shawn Guo
2011-02-05  2:08 ` [PATCH 3/5] ARM: mxs: dynamically allocate dma device for mx23/28 Shawn Guo
2011-02-07  8:09   ` Sascha Hauer [this message]
2011-02-09  0:22     ` Shawn Guo
2011-02-05  2:08 ` [PATCH 4/5] ARM: mxs/mx23evk: add dma device Shawn Guo
2011-02-05  2:08 ` [PATCH 5/5] ARM: mxs/mx28evk: " Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110207080945.GH9041@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).