From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: map ATAGs when not in first 1MB of RAM
Date: Mon, 7 Feb 2011 08:23:03 -0800 [thread overview]
Message-ID: <20110207162302.GJ20795@atomide.com> (raw)
In-Reply-To: <4D42DC71.5080606@gmail.com>
* Rob Herring <robherring2@gmail.com> [110128 07:10]:
> Russell,
>
> On 01/28/2011 08:10 AM, Russell King - ARM Linux wrote:
> >On Fri, Jan 28, 2011 at 08:00:46AM -0600, Rob Herring wrote:
> >>@@ -206,11 +206,17 @@ __create_page_tables:
> >> #endif
> >>
> >> /*
> >>- * Then map first 1MB of ram in case it contains our boot params.
> >>+ * Then map boot params address in r2 or
> >>+ * the first 1MB of ram if boot params address is not specified.
> >> */
> >>- add r0, r4, #PAGE_OFFSET>> 18
> >>- orr r6, r7, r8
> >>- str r6, [r0]
> >>+ mov r0, r2, lsr #20
> >>+ movs r0, r0, lsl #20
> >>+ moveq r0, r8
> >>+ sub r3, r0, r8
> >>+ add r3, r3, #PAGE_OFFSET
> >>+ add r3, r4, r3, lsr #18
> >>+ orr r6, r7, r0
> >>+ str r6, [r3]
> >
> >Wouldn't:
> > str r6, [r4, r3, lsr #18]
> >work here?
>
> Not on Thumb2:
>
> arch/arm/kernel/head.S:218: Error: Thumb supports only LSL in
> shifted register indexing -- `str r6,[r4,r3,lsr#18]'
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2011-02-07 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 14:00 [PATCH v2] ARM: map ATAGs when not in first 1MB of RAM Rob Herring
2011-01-28 14:10 ` Russell King - ARM Linux
2011-01-28 15:10 ` Rob Herring
2011-02-07 16:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207162302.GJ20795@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).