From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Correct WFE() in asm/spinlock.h for Thumb-2
Date: Tue, 8 Feb 2011 16:40:09 +0000 [thread overview]
Message-ID: <20110208164009.GD27521@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1297178414-20983-1-git-send-email-dave.martin@linaro.org>
On Tue, Feb 08, 2011 at 03:20:14PM +0000, Dave Martin wrote:
> The content for ALT_SMP() in the definition of WFE() expands to 6
> bytes (IT cc ; WFEcc.W), which breaks the assumptions of the fixup
> code, leading to lockups when the affected code gets run.
Why does it? My understanding is that the .w suffix forces the assembler
to use the ARM encoding for the instruction.
Thumb2 is just far too weird to understand. I think I'll just stick to
writing good ARM code and let people sort out the Thumb2 weirdnesses.
next prev parent reply other threads:[~2011-02-08 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 15:20 [PATCH] ARM: Correct WFE() in asm/spinlock.h for Thumb-2 Dave Martin
2011-02-08 16:40 ` Russell King - ARM Linux [this message]
2011-02-08 16:56 ` Dave Martin
2011-02-09 10:20 ` Will Deacon
2011-02-09 13:04 ` Russell King - ARM Linux
2011-02-09 16:38 ` Nicolas Pitre
2011-02-09 17:00 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208164009.GD27521@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).