From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration
Date: Thu, 10 Feb 2011 21:55:07 +0100 [thread overview]
Message-ID: <20110210205507.GC2027@pengutronix.de> (raw)
In-Reply-To: <4D53EE2C.2030209@free.fr>
On Thu, Feb 10, 2011 at 02:54:52PM +0100, Julien Boibessot wrote:
> Hi Sascha,
>
> Sascha Hauer a ?crit :
> > The patch is probably fine. Can you provide a better commit log,
> > something like 'fixes uart3 on $myboard'?
> >
> yes, I will try :-)
> > >From looking at the datasheet it is not clear to me how the current pin
> > configuration bahaves. It looks like a uart tx loopback in the iomuxer.
> > Is this correct?
> >
> Well I just reverted the setting back to what it was on 2.6.36, before
> the recent MX51 iomux reorganisation.
> IOMUXC_UART2_IPP_UART_RXD_MUX_SELECT_INPUT register (0x09ec) shouldn't
> be used to configure UART2_TXD PAD, otherwise you overwrite current
> UART2_RXD PAD config.
> Current pin configuration seems to act as a kind of Tx->Rx loopback, yes.
Ok, would be good to have this in the commit log aswell.
Sascha
>
> Without my patch, my board (not mainlined yet) can't receive anything on
> UART2 (used as console).
>
> Julien
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-02-10 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 9:54 [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration julien.boibessot at free.fr
2011-02-10 13:10 ` Sascha Hauer
2011-02-10 13:54 ` Julien Boibessot
2011-02-10 20:55 ` Sascha Hauer [this message]
2011-02-11 8:16 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210205507.GC2027@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).