From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] mx31: add support for the bugbase 1.3 from buglabs
Date: Sun, 13 Feb 2011 22:18:55 +0100 [thread overview]
Message-ID: <20110213211855.GC13279@pengutronix.de> (raw)
In-Reply-To: <1297545419-31181-1-git-send-email-GNUtoo@no-log.org>
Hi Denis,
On Sat, Feb 12, 2011 at 10:16:59PM +0100, Denis 'GNUtoo' Carikli wrote:
> This work was based on bug-linux-2.6.30.patch that can be found
> in buglabs's svn here:
> svn://bugcamp.net/bug/branches/izzy/experimental
>
> Note that the hardware schematics and documentations can be obtained
> here: http://www.bugcommunity.com/wiki/index.php/BUGbase
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
The patch looks good to me now. If you want to make me still more
happy, there are still two minor things to optimize:
- don't reference the history of the patch in the commit log. This is
quite useless once the commit made it into Linus' tree. (The info
might still be interesting, but then put it after the tripple dash
below. Then it won't make it into git.)
- there is a trailing empty line in bug_board_init()
Maybe Sascha can fix this up when taking the patch? (Assuming the
others are happy now, too of course.)
And I wonder there is no copyright statement by you in
arch/arm/mach-mx3/mach-bug.c, maybe because you consider your changes
too minor to be relevant? (INAL and I don't know who to value your
contribution.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-02-13 21:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 21:15 [PATCH] mx31: add support for the bugbase 1.3 from buglabs Denis 'GNUtoo' Carikli
2011-02-10 21:41 ` Marc Kleine-Budde
2011-02-11 2:42 ` Fabio Estevam
2011-02-11 8:10 ` Uwe Kleine-König
2011-02-11 9:21 ` [PATCH 1/3] ARM: mx3+mx5: rename to ${machine}_init Uwe Kleine-König
2011-02-11 9:23 ` [PATCH 1/3 v2] ARM: mx3+mx5: rename mxc_board_init " Uwe Kleine-König
2011-02-11 9:21 ` [PATCH 2/3] ARM: mx3: remove some useless comments Uwe Kleine-König
2011-02-11 9:21 ` [PATCH 3/3] ARM: mx3/mx31ads: fix comments of irq callbacks Uwe Kleine-König
2011-02-11 21:06 ` [PATCH] mx31: add support for the bugbase 1.3 from buglabs Denis 'GNUtoo' Carikli
2011-02-11 21:09 ` Denis 'GNUtoo' Carikli
2011-02-11 21:13 ` Denis 'GNUtoo' Carikli
2011-02-11 21:39 ` Uwe Kleine-König
2011-02-11 23:06 ` Denis 'GNUtoo' Carikli
2011-02-13 21:12 ` Uwe Kleine-König
2011-02-11 21:30 ` Marc Kleine-Budde
2011-02-12 20:15 ` Denis 'GNUtoo' Carikli
2011-02-11 21:33 ` Uwe Kleine-König
2011-02-12 21:16 ` [PATCHv3] " Denis 'GNUtoo' Carikli
2011-02-13 21:18 ` Uwe Kleine-König [this message]
2011-02-14 1:12 ` Denis 'GNUtoo' Carikli
2011-02-17 15:23 ` Denis 'GNUtoo' Carikli
2011-02-17 22:53 ` Uwe Kleine-König
2011-02-18 5:47 ` [bug-dev] " Ken Gilmer
2011-02-18 21:22 ` [PATCH] " Denis 'GNUtoo' Carikli
2011-02-18 21:38 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110213211855.GC13279@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).