From mboxrd@z Thu Jan 1 00:00:00 1970 From: kirill@shutemov.name (Kirill A. Shutemov) Date: Thu, 17 Feb 2011 02:42:13 +0200 Subject: [klibc] fwd: fix up ARM assembly to use 'bx lr' in place of 'mov pc, lr'. In-Reply-To: References: <20110216230648.GA7649@stro.at> <20110216235019.GA17674@shutemov.name> Message-ID: <20110217004213.GA19028@shutemov.name> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 16, 2011 at 04:03:07PM -0800, Khem Raj wrote: > On Wed, Feb 16, 2011 at 3:50 PM, Kirill A. Shutemov > wrote: > > On Thu, Feb 17, 2011 at 12:06:48AM +0100, maximilian attems wrote: > >> hello vorlon, > >> > >> got notified of your patch, > >> will apply next days upstream unless some critiques are voiced on ml. > >> thanks. > >> > >> -- > >> maks > >> > >> > >> ----- Forwarded message from Steve Langasek ----- > >> > >> Date: Wed, 16 Feb 2011 22:05:42 -0000 > >> From: Steve Langasek > >> Subject: [Bug 527720] Re: thumb2 porting issues identified: klibc uses mov.*pc > >> > >> > >> I've also touched it up to be mergeable with Debian (support v4t builds > >> with #ifdef). > >> > >> Confirmed that installing the resulting klibc packages on my beagleboard > >> gives me a successfully-booting initramfs with klibc; and the > >> vfork/setjmptest test cases all pass in the klibc package tree. > >> > >> Fixes: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/527720 > >> > >> --- klibc-1.5.20.orig/usr/klibc/arch/arm/vfork.S > >> +++ klibc-1.5.20/usr/klibc/arch/arm/vfork.S > >> @@ -25,7 +25,11 @@ vfork: > >> ? ? ? ? ?ldrcs ? ? ? ?r3, 1f > >> ? ? ? ? ?mvncs ? ? ? ?r0, #0 > >> ? ? ? ? ?strcs ? ? ? ?r2, [r3] > >> +#if defined (___ARM_ARCH_4T__) || defined (__ARM_ARCH_4__) > > > > NAK. ARMv4T supports bx intruction. ARMv4 doesn't. > > Does ARMv4t support BX lr ? Sure. See http://wiki.debian.org/ArmEabiPort -- Kirill A. Shutemov