linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] omap4: 4430sdp: drop ehci support
Date: Thu, 17 Feb 2011 09:47:06 +0200	[thread overview]
Message-ID: <20110217074706.GD2439@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110217014210.GL20795@atomide.com>

On Wed, Feb 16, 2011 at 05:42:10PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [110216 03:25]:
> > On Wed, Feb 16, 2011 at 04:47:19PM +0530, Anand Gadiyar wrote:
> > > Most revisions of the OMAP4 Blaze/SDP platform do not have
> > > the EHCI signals routed by default. The pads are routed
> > > for the alternate HSI functionality instead, and explicit
> > > board modifications are needed to route the signals to
> > > the USB PHY on the board.
> > > 
> > > Also, turning on the PHY connected to the EHCI port causes
> > > a board reboot during bootup due to an unintended short
> > > on the rails - this affects many initial revisions of the
> > > board, and needs a minor board mod to fix (or as a
> > > workaround, one should not attempt to power on the
> > > USB PHY).
> > > 
> > > Given that these boards need explicit board mods to even
> > > get EHCI working (separate from the accidental short above),
> > > we should not attempt to enable EHCI by default.
> > > 
> > > So drop the EHCI support from the board files for the
> > > Blaze/SDP platforms.
> > > 
> > > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > > Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > 
> > Tony, if you want to queue this one directly, here's my:
> > 
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > 
> > if you wish, I can send you a pull request as well. I already have
> > another patch for you anyway.
> 
> OK if you have more I'd rather pull.

ok. Taken.

-- 
balbi

  reply	other threads:[~2011-02-17  7:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16 11:17 [PATCH 1/2] omap4: 4430sdp: drop ehci support Anand Gadiyar
2011-02-16 11:17 ` [PATCH 2/2] omap4: 4430sdp: mux GPIO_157 to safe mode Anand Gadiyar
2011-02-16 11:26 ` [PATCH 1/2] omap4: 4430sdp: drop ehci support Felipe Balbi
2011-02-17  1:42   ` Tony Lindgren
2011-02-17  7:47     ` Felipe Balbi [this message]
2011-02-17  7:49 ` Felipe Balbi
2011-02-17 11:49 ` Russell King - ARM Linux
2011-02-17 14:04   ` Anand Gadiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217074706.GD2439@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).