From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] mtd: OneNAND: OMAP2: increase multiblock erase verify timeout
Date: Thu, 17 Feb 2011 15:46:03 -0800 [thread overview]
Message-ID: <20110217234603.GI20795@atomide.com> (raw)
In-Reply-To: <1297068421-14430-5-git-send-email-adrian.hunter@nokia.com>
* Adrian Hunter <adrian.hunter@nokia.com> [110207 00:45]:
> From: Roman Tereshonkov <roman.tereshonkov@nokia.com>
>
> The current multiblock erase verify read timeout 100us is the maximum
> for none-error case. If errors happen during multibock erase then
> the specification recommends to run multiblock erase verify command
> with maximum timeout 10ms (see specs. for KFM4G16Q2A and KFN8G16Q2A).
>
> For the most common non-error case we wait 100us in udelay polling
> loop. In case of timeout the interrupt mode is used to wait for the
> command end.
>
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
I'll queue this series. Anybody from MTD list care to ack this patch?
Regards,
Tony
> ---
> drivers/mtd/onenand/omap2.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 3e1bb95..ec26399 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -148,11 +148,9 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
> wait_err("controller error", state, ctrl, intr);
> return -EIO;
> }
> - if ((intr & intr_flags) != intr_flags) {
> - wait_err("timeout", state, ctrl, intr);
> - return -EIO;
> - }
> - return 0;
> + if ((intr & intr_flags) == intr_flags)
> + return 0;
> + /* Continue in wait for interrupt branch */
> }
>
> if (state != FL_READING) {
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2011-02-17 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 8:46 [PATCH 0/4] Fix 104MHz support for OMAP OneNAND Adrian Hunter
2011-02-07 8:46 ` [PATCH 1/4] OMAP: OneNAND: fix 104MHz support Adrian Hunter
2011-02-07 8:46 ` [PATCH 2/4] OMAP: OneNAND: determine frequency in one place Adrian Hunter
2011-02-07 8:47 ` [PATCH 3/4] OMAP: OneNAND: let boards determine OneNAND frequency Adrian Hunter
2011-02-07 8:47 ` [PATCH 4/4] mtd: OneNAND: OMAP2: increase multiblock erase verify timeout Adrian Hunter
2011-02-17 23:46 ` Tony Lindgren [this message]
2011-02-18 4:31 ` Artem Bityutskiy
2011-02-18 17:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217234603.GI20795@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).