From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros
Date: Fri, 18 Feb 2011 00:45:22 +0000 [thread overview]
Message-ID: <20110218004522.GA27462@gallagher> (raw)
In-Reply-To: <cb015a68-c46f-400b-97ba-e1bf32e8dc2c@VA3EHSMHS019.ehs.local>
On Thu, Feb 17, 2011 at 05:37:47PM -0700, John Linn wrote:
> > > +static inline void arch_reset(char mode, const char *cmd)
> > > +{
> > > + /* Add architecture specific reset processing here */
> >
> > I think you can add cpu_reset(0) in here to try a soft reset by
> jumping
> > to the reset vector. This should give you some reset functionality.
>
> Hi Jamie,
>
> How strongly do you feel that this has to be in on this initial patch
> set?
>
> There will be many more coming later and I'd like to postpone that one
> as it's really additional
> functionality vs a bug (to me anyway).
I don't have a strong opinion on it. If you leave it as it is so that
arch_reset() will return then the generic ARM code will issue a printk
to tell the user that it failed then drop into an infinite loop so it
should be obvious that reset isn't implemented!
If reset is nontrivial then you're probably right to leave it out of
this patch and put it into another later on.
Jamie
next prev parent reply other threads:[~2011-02-18 0:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297872716-13353-1-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-02-17 9:34 ` Jamie Iles
2011-02-17 14:24 ` John Linn
[not found] ` <1297872716-13353-2-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-02-17 9:48 ` Jamie Iles
2011-02-17 14:27 ` John Linn
[not found] ` <1297872716-13353-3-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-17 10:01 ` Jamie Iles
2011-02-17 14:31 ` John Linn
2011-02-17 14:41 ` Arnd Bergmann
2011-02-17 15:12 ` Russell King - ARM Linux
2011-02-17 15:18 ` Arnd Bergmann
2011-02-17 21:58 ` Stephen Boyd
2011-02-18 1:29 ` John Linn
2011-02-18 0:37 ` John Linn
2011-02-18 0:45 ` Jamie Iles [this message]
2011-02-18 1:19 ` John Linn
2011-02-18 9:06 ` Jamie Iles
2011-02-18 13:59 ` John Linn
2011-02-18 14:28 ` John Linn
[not found] ` <1297872716-13353-4-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218004522.GA27462@gallagher \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).