linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] PRUSS UIO driver support
Date: Sat, 19 Feb 2011 13:26:42 +0000	[thread overview]
Message-ID: <20110219132642.GD29493@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1298041530-26855-2-git-send-email-pratheesh@ti.com>

On Fri, Feb 18, 2011 at 08:35:29PM +0530, Pratheesh Gangadhar wrote:
> +static int __devinit pruss_probe(struct platform_device *dev)
> +{
> +	int ret = -ENODEV;
> +	int count = 0;
> +	struct resource *regs_pruram, *regs_l3ram, *regs_ddr;
> +	char *string;
> +
> +	/* Power on PRU in case its not done as part of boot-loader */
> +	pruss_clk = clk_get(&dev->dev, "pruss");
> +	if (IS_ERR(pruss_clk)) {
> +		dev_err(&dev->dev, "Failed to get clock\n");
> +		ret = PTR_ERR(pruss_clk);
> +		pruss_clk = NULL;

Delete this line.

...
> +out_free:
> +	for (count = 0; count < MAX_PRUSS_EVTOUT_INSTANCE; count++)
> +		kfree(info[count]);
> +
> +	if (pruss_clk != NULL)

	if (!IS_ERR(pruss_clk))

> +		clk_put(pruss_clk);
...
> +static int __devexit pruss_remove(struct platform_device *dev)
...
> +	platform_set_drvdata(dev, NULL);
> +
> +	if (pruss_clk != NULL)

	if (!IS_ERR(pruss_clk))

> +		clk_put(pruss_clk);

      parent reply	other threads:[~2011-02-19 13:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 15:05 [PATCH 0/2] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-02-18 15:05 ` [PATCH 1/2] " Pratheesh Gangadhar
2011-02-18 15:05   ` [PATCH 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources used by PRUSS UIO driver Pratheesh Gangadhar
2011-02-21 17:10     ` Sergei Shtylyov
2011-02-22 11:38       ` TK, Pratheesh Gangadhar
2011-02-18 15:44   ` [PATCH 1/2] PRUSS UIO driver support Arnd Bergmann
2011-02-18 16:15     ` Thomas Gleixner
2011-02-18 16:31       ` Arnd Bergmann
2011-02-18 17:03         ` Thomas Gleixner
2011-02-19 15:40           ` TK, Pratheesh Gangadhar
2011-02-19 18:34             ` Hans J. Koch
2011-02-21  3:57               ` TK, Pratheesh Gangadhar
2011-02-21 19:33                 ` Hans J. Koch
2011-02-21 19:37                   ` Thomas Gleixner
2011-02-21 19:53                   ` Sergei Shtylyov
2011-02-22 12:06                     ` TK, Pratheesh Gangadhar
2011-02-19 10:19     ` TK, Pratheesh Gangadhar
2011-02-18 16:31   ` Hans J. Koch
2011-02-18 17:05     ` Greg KH
2011-02-19 16:06       ` TK, Pratheesh Gangadhar
2011-02-19 11:30     ` TK, Pratheesh Gangadhar
2011-02-18 16:51   ` Thomas Gleixner
2011-02-19 12:47     ` TK, Pratheesh Gangadhar
2011-02-19 13:26   ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110219132642.GD29493@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).