From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] MMC: error handling improvements
Date: Sat, 19 Feb 2011 15:00:06 +0000 [thread overview]
Message-ID: <20110219150006.GH29493@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <8yaoc6c7tan.fsf@huya.qualcomm.com>
On Tue, Feb 15, 2011 at 03:49:04PM -0800, David Brown wrote:
> On Tue, Feb 15 2011, Russell King - ARM Linux wrote:
>
> > This patch is for RFC only; it needs splitting up somewhat. However, I
> > wanted to get it out there for some comment.
>
> Just for kicks, I applied this and ran it on an MSM target (8x50). It
> seems to cause lots of:
>
> mmc0: Data timeout
> mmc0: Controller has been re-initialized
> ...
> mmc0: Data CRC error
>
> and I can post more if you would find them interesting. Eventually the
> MSM mmc driver derefernces a null pointer in the interrupt code.
That doesn't look right. If resetting the MMC controller results in all
state being lost, it presumably means the card gets powered down too.
If that happens, the card needs to be reinitialized from scratch again,
and I don't see how that happens in this driver.
Nothing in this patch should cause data timeouts to appear where they
weren't already appearing before the patch - the patch only changes
what happens after an error occurs, so you must already be encountering
errors on the interface before you applied this patch.
next prev parent reply other threads:[~2011-02-19 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 23:03 [RFC] MMC: error handling improvements Russell King - ARM Linux
2011-02-15 23:49 ` David Brown
2011-02-16 18:41 ` Linus Walleij
2011-02-16 19:28 ` David Brown
2011-02-16 21:01 ` Linus Walleij
2011-02-16 23:06 ` Brian Swetland
2011-02-18 13:03 ` Linus Walleij
2011-02-18 16:04 ` Brian Swetland
2011-02-21 20:49 ` Linus Walleij
[not found] ` <AANLkTimpJUoc64py_jCrvsrXscawsR2c7JBtr1e0U+e8@mail.gmail.com>
2011-03-01 18:39 ` Fwd: " Murali Krishna Palnati
2011-03-01 20:22 ` Russell King - ARM Linux
2011-03-02 10:12 ` Linus Walleij
2011-02-19 15:00 ` Russell King - ARM Linux [this message]
2011-03-01 13:28 ` Sahitya Tummala
2011-02-16 19:01 ` Pawel Moll
2011-02-17 10:40 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219150006.GH29493@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).