linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: imx: Zero entire imxdma structure
Date: Sun, 20 Feb 2011 23:04:58 +0000	[thread overview]
Message-ID: <20110220230458.GA21198@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTin4gJpzV6-bo15rn_AHVGvTD8+9vq3Q+ciLF8vB@mail.gmail.com>

On Sun, Feb 20, 2011 at 10:59:24PM +0000, Ilia Mirkin wrote:
> On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> > The semantic match that finds the problem:
> > // <smpl>
> > @@
> > type T;
> > identifier x;
> > @@
> >
> > T *x;
> > ...
> > * memset(x, ..., ... * sizeof(x) * ...);
> > // </smpl>
> >
> > Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
> >
> > ---
> > ?arch/arm/mach-imx/dma-v1.c | ? ?2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Untested, lack of tool chain and hardware. But there's definitely something
> > odd going on here, and this seemed like the most logical fix.
> 
> Doing some quick digging (as I've been discovering that a few of the
> other patches I was planning on sending have already been sent out in
> the past), I noticed that this same patch was already sent on Dec 9,
> 2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and
> then again by Vasiliy Kulikov[2] on Oct 10, 2010.
> 
> On each occasion, the response was positive, but patch has yet to make
> it upstream. Weird.

Sascha, are you going to take this patch?

  reply	other threads:[~2011-02-20 23:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20 22:10 [PATCH] arm: imx: Zero entire imxdma structure Ilia Mirkin
2011-02-20 22:59 ` Ilia Mirkin
2011-02-20 23:04   ` Russell King - ARM Linux [this message]
2011-02-21 16:00     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110220230458.GA21198@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).