From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sun, 20 Feb 2011 23:04:58 +0000 Subject: [PATCH] arm: imx: Zero entire imxdma structure In-Reply-To: References: <1298239851-958-1-git-send-email-imirkin@alum.mit.edu> Message-ID: <20110220230458.GA21198@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Feb 20, 2011 at 10:59:24PM +0000, Ilia Mirkin wrote: > On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin wrote: > > The semantic match that finds the problem: > > // > > @@ > > type T; > > identifier x; > > @@ > > > > T *x; > > ... > > * memset(x, ..., ... * sizeof(x) * ...); > > // > > > > Signed-off-by: Ilia Mirkin > > > > --- > > ?arch/arm/mach-imx/dma-v1.c | ? ?2 +- > > ?1 files changed, 1 insertions(+), 1 deletions(-) > > > > Untested, lack of tool chain and hardware. But there's definitely something > > odd going on here, and this seemed like the most logical fix. > > Doing some quick digging (as I've been discovering that a few of the > other patches I was planning on sending have already been sent out in > the past), I noticed that this same patch was already sent on Dec 9, > 2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and > then again by Vasiliy Kulikov[2] on Oct 10, 2010. > > On each occasion, the response was positive, but patch has yet to make > it upstream. Weird. Sascha, are you going to take this patch?