From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: mxs: add dma device
Date: Tue, 22 Feb 2011 19:30:36 +0100 [thread overview]
Message-ID: <20110222183036.GB22310@pengutronix.de> (raw)
In-Reply-To: <20110222122733.GD19871@S2100-06.ap.freescale.net>
Hi Shawn,
On Tue, Feb 22, 2011 at 08:27:34PM +0800, Shawn Guo wrote:
> > > diff --git a/arch/arm/mach-mxs/devices/platform-dma.c b/arch/arm/mach-mxs/devices/platform-dma.c
> > > new file mode 100644
> > > index 0000000..ee3220e
> > > --- /dev/null
> > > +++ b/arch/arm/mach-mxs/devices/platform-dma.c
> > I'd prefer to have that called platform-mxs-dma.c to match the driver
> > name. (At least that's what you use for the data structs.)
> >
> If you put this comment a little bit earlier on platform-auart.c which
> is the first example that saves the "mxs" from driver name, I would
> have platform-mxs-dma.c and platform-mxs-mmc.c from the start.
I already noticed I missed auart and planned to follow up with a patch.
Sorry if this resulted in an extra iteration for you.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-02-22 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 10:31 [PATCH v3 0/2] Add dma device for i.MX23/28 Shawn Guo
2011-02-21 10:31 ` [PATCH v3 1/2] ARM: mxs: add dma channel definitions Shawn Guo
2011-02-21 10:31 ` [PATCH v3 2/2] ARM: mxs: add dma device Shawn Guo
2011-02-22 7:52 ` Sascha Hauer
2011-02-22 12:34 ` Shawn Guo
2011-02-22 8:09 ` Uwe Kleine-König
2011-02-22 12:27 ` Shawn Guo
2011-02-22 18:30 ` Uwe Kleine-König [this message]
2011-02-23 3:09 ` Shawn Guo
2011-02-22 13:36 ` [PATCH v4] " Shawn Guo
2011-02-21 17:20 ` [PATCH v3 0/2] Add dma device for i.MX23/28 Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222183036.GB22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).