From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nmk-gpio: use request_irq instead of chained handler
Date: Wed, 23 Feb 2011 13:18:05 +0000 [thread overview]
Message-ID: <20110223131805.GK29559@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1298465690-27077-1-git-send-email-rabin.vincent@stericsson.com>
On Wed, Feb 23, 2011 at 06:24:50PM +0530, Rabin Vincent wrote:
> __nmk_gpio_irq_handler doesn't do anything more that what a normal handler
> does, so it can become one. This is also needed for changing the GIC
> implementation to a different flow handler.
So you want to allow other people to request the GPIO interrupt?
You also want to have the IRQ tracing code called once for entry into
this handler and once for each GPIO interrupt which is pending?
You want to have the overhead of dealing with the inprogress stuff, etc?
I really don't like the idea of getting rid of the interrupt chaining
and reverting back to the proven-to-be-broken 2.2 kernel way of handing
this kind of thing - which is exactly what you're doing here.
next prev parent reply other threads:[~2011-02-23 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 12:54 [PATCH] nmk-gpio: use request_irq instead of chained handler Rabin Vincent
2011-02-23 13:18 ` Russell King - ARM Linux [this message]
2011-02-23 15:22 ` Rabin Vincent
2011-02-23 17:17 ` Will Deacon
[not found] ` <-6148324460357957969@unknownmsgid>
2011-02-23 17:25 ` Rabin Vincent
2011-02-23 17:36 ` Will Deacon
[not found] ` <5890487119819559395@unknownmsgid>
2011-02-25 16:59 ` Linus Walleij
2011-02-25 17:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223131805.GK29559@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).