From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2+: clocksource: fix crash on boot when !CONFIG_OMAP_32K_TIMER
Date: Thu, 24 Feb 2011 13:13:29 -0800 [thread overview]
Message-ID: <20110224211328.GK20560@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102241330500.6198@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [110224 12:29]:
> On Thu, 24 Feb 2011, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul@pwsan.com> [110222 18:58]:
> > >
> > > OMAP2+ kernels built without CONFIG_OMAP_32K_TIMER crash on boot after the
> > > 2.6.38 sched_clock changes:
> > >
> > > [ 0.000000] OMAP clockevent source: GPTIMER1 at 13000000 Hz
> > > [ 0.000000] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> > > [ 0.000000] pgd = c0004000
> > > [ 0.000000] [00000000] *pgd=00000000
> > > [ 0.000000] Internal error: Oops: 80000005 [#1] SMP
> > > [ 0.000000] last sysfs file:
> > > [ 0.000000] Modules linked in:
> > > [ 0.000000] CPU: 0 Not tainted (2.6.38-rc5-00057-g04aa67d #152)
> > > [ 0.000000] PC is at 0x0
> > > [ 0.000000] LR is at sched_clock_poll+0x2c/0x3c
> > >
> > > Without CONFIG_OMAP_32K_TIMER, the kernel has an clockevent and
> > > clocksource resolution about three orders of magnitude higher than
> > > with CONFIG_OMAP_32K_TIMER set. The tradeoff is that the lowest
> > > power consumption states are not available.
> > >
> > > Fix by calling init_sched_clock() from the GPTIMER clocksource init code.
> >
> > I'll queue this as a fix as it's a regression.
>
> Sounds good, I've got one or two other -rc candidates. Want me to build a
> branch with this and the other two?
Well I already applied this one. But for the two others yes please.
Tony
next prev parent reply other threads:[~2011-02-24 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 2:59 [PATCH] OMAP2+: clocksource: fix crash on boot when !CONFIG_OMAP_32K_TIMER Paul Walmsley
2011-02-24 20:21 ` Tony Lindgren
2011-02-24 20:31 ` Paul Walmsley
2011-02-24 21:13 ` Tony Lindgren [this message]
2011-02-25 20:16 ` OMAP2+: clock/MPU prcm: patches for the 2.6.38-rc series Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224211328.GK20560@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).