From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 2/2] efika mx/sb: enable watchdog
Date: Mon, 28 Feb 2011 15:47:45 +0100 [thread overview]
Message-ID: <20110228144745.GL22310@pengutronix.de> (raw)
In-Reply-To: <20110228132646.494426111@rtp-net.org>
Hi Arnaud,
just one nitpick below ...
On Mon, Feb 28, 2011 at 02:21:34PM +0100, Arnaud Patard wrote:
> Register watchdog for efika mx and sb systems.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>
> Index: linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/mx51_efika.c 2011-02-27 23:13:37.000000000 +0100
> +++ linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c 2011-02-27 23:20:38.000000000 +0100
> @@ -611,6 +611,7 @@
> ARRAY_SIZE(mx51efika_pads));
> imx51_add_imx_uart(0, &uart_pdata);
> mx51_efika_usb();
> + imx51_add_imx2_wdt(0, NULL);
> imx51_add_sdhci_esdhc_imx(0, NULL);
>
> /* FIXME: comes from original code. check this. */
> Index: linux-2.6-submit/arch/arm/mach-mx5/Kconfig
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/Kconfig 2011-02-27 23:13:42.000000000 +0100
> +++ linux-2.6-submit/arch/arm/mach-mx5/Kconfig 2011-02-27 23:20:38.000000000 +0100
> @@ -117,6 +117,7 @@
> bool
> select SOC_IMX51
> select IMX_HAVE_PLATFORM_IMX_UART
> + select IMX_HAVE_PLATFORM_IMX2_WDT
> select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
> select IMX_HAVE_PLATFORM_SPI_IMX
These IMX_HAVE_PLATFORM entries are sorted alphabetically and 2 sorts
before _, so IMX_HAVE_PLATFORM_IMX2_WDT should be the first entry here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2011-02-28 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 13:21 [patch 0/2] Get watchdog reboot working on efika smartbook Arnaud Patard (Rtp)
2011-02-28 13:21 ` [patch 1/2] mc13892: reboot on wdi event Arnaud Patard (Rtp)
2011-02-28 14:35 ` Mark Brown
2011-02-28 15:25 ` Arnaud Patard (Rtp)
2011-02-28 18:11 ` Mark Brown
2011-02-28 19:19 ` Arnaud Patard (Rtp)
2011-03-01 20:56 ` Liam Girdwood
2011-02-28 14:37 ` Mark Brown
2011-02-28 15:30 ` Arnaud Patard (Rtp)
2011-02-28 13:21 ` [patch 2/2] efika mx/sb: enable watchdog Arnaud Patard (Rtp)
2011-02-28 14:47 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228144745.GL22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).